From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E280EEB64DA for ; Wed, 28 Jun 2023 19:19:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230315AbjF1TTD (ORCPT ); Wed, 28 Jun 2023 15:19:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231379AbjF1TSw (ORCPT ); Wed, 28 Jun 2023 15:18:52 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 954B61FF1 for ; Wed, 28 Jun 2023 12:18:50 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-5702116762fso1842407b3.3 for ; Wed, 28 Jun 2023 12:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687979930; x=1690571930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7DUD/shWe46KMvA0LBMlGn2qbYD6iSa8fQ8POxlPlXM=; b=bwFjvvNcUJo7//TF8Jp1vEu1xBV6qJmdrgeX0/ANiiVkekDwHHURXv+DV88cWYT6jW RbHZEIn3r9PtHYcU4fIMjie5zJI6IS0zU0Yq+6jHzzBqH1S+8mbos0IDAI3y4O1YxynU imdW1P2optY818M2gbNF5hU4q2ZU/cpterMPuJEU5VtKZ63vv5BOPOYpaOXFEVDcJCZe njEyQ1uoFmFpp8jWN7ztedU+45WHoCMjLCJHxIZUoYY3yo0OHqUkekyUbJVC4tKKMOka OguEhhd/Ez61qhzCh0w6nIJMbVWfYEit5vhI4og1FaIZ6NwTsVbGXZoQEAU8iEt/P0Zs bmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687979930; x=1690571930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7DUD/shWe46KMvA0LBMlGn2qbYD6iSa8fQ8POxlPlXM=; b=G7d1v8or+FyiJ5fTFEv60LczoxzN8MsSYXHNJCWO+rh6EpO3BfewZJvUHArf6KGjow /3uL8+25FvTWTIcgXC389KzOiI3vHDthfaG6O+LwUkpGXeg/l+I3l1bG+mzXdWSy18+6 nfgxi7D8IDAWKboKO7akcVrnFTrbyNl/bf84VroGsrrTlhmqG9+kUbdDB3VM30DVUEcr j22adUPnRBvgqmPHO21qVM9bpc0z3gDTQi3e3XOKOuinbXDTstpwNI4f2meDEJ2KN5zR mrMO8zESjOUED6hCqYksoaRUf3yJvoWRHFe5G4H2Gm1m0D4CEfbejTF07w6HLXPzSrlq u4rA== X-Gm-Message-State: AC+VfDzjkL3IQRv3DXFZ/Qk+K9nKOqnT1boEsvEaVMnIkpF5k/R3l8Dx Aa0jtOQt1UIHnRoD6pBrQ3zaFeXxgl3yEAaZ1YNfKA== X-Google-Smtp-Source: ACHHUZ7rpDB3iLiEU8xufHcYAsfVBnrCQGv7FT1VlaIgweQmvXwzogrWdJylssczyf5duNaEFnucjJqA02PevJT363c= X-Received: by 2002:a05:6902:91:b0:bb8:4cc6:9d09 with SMTP id h17-20020a056902009100b00bb84cc69d09mr28026725ybs.29.1687979929795; Wed, 28 Jun 2023 12:18:49 -0700 (PDT) MIME-Version: 1.0 References: <20230521-drm-panels-sony-v1-0-541c341d6bee@somainline.org> <20230521-drm-panels-sony-v1-10-541c341d6bee@somainline.org> In-Reply-To: From: Linus Walleij Date: Wed, 28 Jun 2023 21:18:38 +0200 Message-ID: Subject: Re: [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1 To: Marijn Suijten Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Caleb Connolly , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , devicetree@vger.kernel.org, Jami Kettunen , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Abhinav Kumar , Konrad Dybcio , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Dmitry Baryshkov , Jessica Zhang , Kuogee Hsieh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2023 at 4:20=E2=80=AFPM Marijn Suijten wrote: > But for now we might already create a step-up version of that by having > a "Samsung panel driver library" to deduplicate generic commands, which > drivers can freely call into? Yeah something like that is likely what we want. > On the other hand of the spectrum we currently have 4 downstream panels > for Sony devices that all declare to be using the sofef01 controller, > but with vastly different command sets. And even if we "accidentally" > send the wrong set for the wrong device, the panel works anyway with no > noticeable color shifts or otherwise... Yeah that is typically the case :/ We should try to group the similar code together and expect that sooner or later we will figure out what display controller(s) it is and name it af= ter that rather than after the panel (which I define as the combination of a display controller and an actual panel). Yours, Linus Walleij