From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-tegra <linux-tegra@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 0/3] Support building gpio-tegra driver as loadable module
Date: Sat, 23 Jan 2021 23:50:07 +0100 [thread overview]
Message-ID: <CACRpkdZTyBuz240iYuvi91k3dLKKXX=4DNxFEBP7mSNB58XtDw@mail.gmail.com> (raw)
In-Reply-To: <20210122185543.16554-1-digetx@gmail.com>
On Fri, Jan 22, 2021 at 7:59 PM Dmitry Osipenko <digetx@gmail.com> wrote:
> This small series adds modularization support to the gpio-tegra driver,
> i.e. driver now could be built as a loadable kernel module.
>
> Dmitry Osipenko (3):
> gpio: tegra: Use debugfs_create_devm_seqfile()
> gpio: tegra: Clean up whitespaces in tegra_gpio_driver
> gpio: tegra: Support building driver as a loadable module
As these three patches clearly make the kernel look better after
than before:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
However when we are doing this I would strongly encourage you
to also make a patch implementing remove() so you can insmod
rmmod the module at runtime.
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-01-23 22:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 18:55 [PATCH v1 0/3] Support building gpio-tegra driver as loadable module Dmitry Osipenko
2021-01-22 18:55 ` [PATCH v1 1/3] gpio: tegra: Use debugfs_create_devm_seqfile() Dmitry Osipenko
2021-01-22 18:55 ` [PATCH v1 2/3] gpio: tegra: Clean up whitespaces in tegra_gpio_driver Dmitry Osipenko
2021-01-22 18:55 ` [PATCH v1 3/3] gpio: tegra: Support building driver as a loadable module Dmitry Osipenko
2021-01-23 22:50 ` Linus Walleij [this message]
2021-01-23 23:56 ` [PATCH v1 0/3] Support building gpio-tegra driver as " Dmitry Osipenko
2021-01-24 22:46 ` Linus Walleij
2021-01-25 14:08 ` Dmitry Osipenko
2021-01-27 14:41 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZTyBuz240iYuvi91k3dLKKXX=4DNxFEBP7mSNB58XtDw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).