From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DBB9C43461 for ; Thu, 6 May 2021 13:00:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39E96610FC for ; Thu, 6 May 2021 13:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232982AbhEFNBk (ORCPT ); Thu, 6 May 2021 09:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbhEFNBi (ORCPT ); Thu, 6 May 2021 09:01:38 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CABBC061574 for ; Thu, 6 May 2021 06:00:39 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id x20so7667477lfu.6 for ; Thu, 06 May 2021 06:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=co6Tu6p7gwdreS8j+kzhyH/BpJmEW7gcEZ8FRox2VLM=; b=imjkp9zgX91dHPVMnXtZjX6RL8An3N4T5kLaqqZ6UKOJo9faTrNHFaPZELcNYuaypq uQ0/erVuIlCfOsrMExtH/3x/rE9AIDaoYdRD7IrMtbmzzNF+jCZ91F3hF4DXulvJ6zP/ MuHOWqMS5MWRUIAAm/gj0Ow6coQgPBzRVIiF0tbBbonfjtA0fkRH7Ofu2gJc4sFh4VdW sMUdEY07akP+Z82iHfIBKrK5uAdOQyVWleVZtjHg9DWsguCqgfIU/qgMkTmCwb6F0X6c dykfROgNLyZEnLXx3Ol6DzFYXh8Gi3IuCvomWSHe7l1JjMTLqe1pyPpxL6b2H45b1H1J TQag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=co6Tu6p7gwdreS8j+kzhyH/BpJmEW7gcEZ8FRox2VLM=; b=SArrZfMa4hchaBsrIifmoMDJO/mAIyciPNlcPT9PuLrSxwbd7l6Kuc3w+RxhFtQ1s0 Qg/tGXX+dAIzGlZBy+fngSrVqnBuT43ojASdrXWD5xqY5RGCfvQ1DqOYfB04dv0KERCt n4WJBUJacG/c2K+A1Jn8nC9eNjhOviPGMv+DhXT3ipdX0o4DD21LyKkmEGQej5wKhK4R sNDGg3Tlj81DUcgUQuWPGF0D+uCLvYJJXh1CjRYRTlPAQH+93iX21v/QmCWyl0TQ1dGC k6YJ2D30Q918u/cpPdb9mDP5UwN61Ec9Y4pRYXJrY7mx4RkqV9yR41m9KVTuMqJvFHYP 0SDQ== X-Gm-Message-State: AOAM5320z4F9kFO2qZadJDFf0PsvQATmnO/IhxsmTvKpP+OCUpDd2M0x SfK558Q0vEOa5tfuE9gDB5thhGtKxLnrFzI14xbruQ== X-Google-Smtp-Source: ABdhPJwechm8k/LJgQ4yWdTtDYG9Go8iYVJJpJ+sWs2TdhwxF8w4kKFdR4XnUVrgxVAIpiJ8CaDV03AcGU3DFLg9ZH0= X-Received: by 2002:a19:a418:: with SMTP id q24mr2688212lfc.649.1620306037628; Thu, 06 May 2021 06:00:37 -0700 (PDT) MIME-Version: 1.0 References: <20210504161222.101536-1-ulf.hansson@linaro.org> <20210504161222.101536-7-ulf.hansson@linaro.org> In-Reply-To: <20210504161222.101536-7-ulf.hansson@linaro.org> From: Linus Walleij Date: Thu, 6 May 2021 15:00:26 +0200 Message-ID: Subject: Re: [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds To: Ulf Hansson Cc: linux-mmc , Adrian Hunter , Wolfram Sang , Shawn Lin , Avri Altman , Masami Hiramatsu , linux-block , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 4, 2021 at 6:12 PM Ulf Hansson wrote: > * NOTE: void *buf, caller for the buf is required to use DMA-capable > * buffer or on-stack buffer (with some overhead in callee). > */ > -static int > -mmc_send_cxd_data(struct mmc_card *card, struct mmc_host *host, > - u32 opcode, void *buf, unsigned len) > +int mmc_send_adtc_data(struct mmc_card *card, struct mmc_host *host, u32 opcode, > + u32 args, void *buf, unsigned len) Just a note here (the change is good) When applying please add some kerneldoc above mmc_send_adtc_data() and expand the ADTC acronym and add some info explaining what it is maybe a small protocol ref or so, so readers of the code get an intuitive feeling for what this function does and what ADTC is. Yours, Linus Walleijq