From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0481C43461 for ; Thu, 6 May 2021 12:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC8056113E for ; Thu, 6 May 2021 12:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232777AbhEFMzA (ORCPT ); Thu, 6 May 2021 08:55:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbhEFMy7 (ORCPT ); Thu, 6 May 2021 08:54:59 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C8DEC061761 for ; Thu, 6 May 2021 05:54:00 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id e12so6901583ljn.2 for ; Thu, 06 May 2021 05:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d+OPQctMT5v0HvXEs0KL3xl4z57JF9IlElnIypbIafY=; b=MdnUPYwzkZPQjM5OIgcsszZlz/F/h+pGFm2t9OL+0ov7BsfZ1hS1jLjDLMxDtn9O2f BlEDl91hDASPTzTf2BPF6Eoq4rdB1K2cwNiUfiFAEFO+DOjeqC96sM65xiAJXtSqj0YP oi6h+ipCV6YG+cxzHUVhZijDusqMUAyWOl539L/2vIyretdReLPTIttMM+PccVAjbscM sA4F1I46sBr+taK3W5lQDClb4IAV8cRsKskb0CFOZq5Du3tKF6zpay/zzczJpoETBnfj RIaTlWujAtqpvW2qQX+gIa8/WvdrZZwWQoSxtViSRP4Wu2oULsxoSRKHqfcFOY8sliJs nRHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d+OPQctMT5v0HvXEs0KL3xl4z57JF9IlElnIypbIafY=; b=MbJ2qe06WuwF8Odh+0JVOdsDIFvOJeadax4Dzw4/vXt8zfDDb78z1RIeK4qHACsuGP vuhoalIOwKyVF4KM8X8JgYoVuPrVz6jaN4zKcsRoJEJytfhFf5q22O6uk54Gnd20lYJp 9dMctf0EX4dn2Xf/YWgXbH32Swru66cW4UQPmVE6cw7pBExIQzl5LH96B710yPJwYuqp lt4vdBSosIrWtuoD+xPqrZeemiZWULHzl5UQcaymckG0qr7QFjaydAR2CvfwLUSA0CoF lt8ZmNY49H4E0Pd1hFcJZuh3joJomKyt9sLdrtTYmz7ZlsU29ZjnQDNYHluu8g/CgJHn qaAA== X-Gm-Message-State: AOAM532hkBL/SYDmVckgG4QgYfh3LtO0V08EwgiYjzYyZhnkpA2naYbs Yx2ASDGw+1YQKkiv7sOC6obQZNAstIRTk6tS1ZvQGw== X-Google-Smtp-Source: ABdhPJwdOYHWiEjJghr3gE+4URcaew1fSeNhWpBS3+NVycFSi/NI/vSXe6Kw3TPGd35JtJGnHS4z1TSO+6fxNN+mrB4= X-Received: by 2002:a2e:a54c:: with SMTP id e12mr3257006ljn.326.1620305638900; Thu, 06 May 2021 05:53:58 -0700 (PDT) MIME-Version: 1.0 References: <20210504161222.101536-1-ulf.hansson@linaro.org> <20210504161222.101536-5-ulf.hansson@linaro.org> In-Reply-To: <20210504161222.101536-5-ulf.hansson@linaro.org> From: Linus Walleij Date: Thu, 6 May 2021 14:53:47 +0200 Message-ID: Subject: Re: [PATCH 04/11] mmc: core: Extend re-use of __mmc_poll_for_busy() To: Ulf Hansson Cc: linux-mmc , Adrian Hunter , Wolfram Sang , Shawn Lin , Avri Altman , Masami Hiramatsu , linux-block , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 4, 2021 at 6:12 PM Ulf Hansson wrote: > Via __mmc_poll_for_busy() we end up polling with the ->card_busy() host ops > or by sending the CMD13. To allow polling of different types, which is > needed to support a few new SD card features, let's rework the code around > __mmc_poll_for_busy() to make it more generic. > > More precisely, let __mmc_poll_for_busy() take a pointer to a callback > function as in-parameter, which it calls to poll for busy state completion. > Additionally, let's share __mmc_poll_for_busy() to allow it to be re-used > outside of mmc_ops.c. Subsequent changes will make use of it. > > Signed-off-by: Ulf Hansson Reviewed-by: Linus Walleij Yours, Linus Walleij