linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Stephen Warren <swarren@nvidia.com>
Cc: Olof Johansson <olof@lixom.net>, Colin Cross <ccross@android.com>,
	linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ARM: tegra: Switch to new pinctrl driver
Date: Tue, 24 Jan 2012 23:36:51 +0100	[thread overview]
Message-ID: <CACRpkdZ_hBviswq7pXoLozC8gjzvowCBrj9yjw1xJT79b5rtwQ@mail.gmail.com> (raw)
In-Reply-To: <1327083746-31430-3-git-send-email-swarren@nvidia.com>

On Fri, Jan 20, 2012 at 7:22 PM, Stephen Warren <swarren@nvidia.com> wrote:

> * Rename old pinmux and new pinctrl platform driver and DT match table
>  entries, so the new driver gets instantiated.
> * Re-write board-pinmux.c, so that it uses pinctrl APIs to configura the
>  pinmux.
> * Re-write board-*-pinmux.c so that the pinmux configuration tables are
>  in pinctrl format.
>
> Ventana's pin mux table needed some edits on top of the basic format
> conversion, since some mux options that were previously marked as
> reserved are now valid in the new pinctrl driver. Attempting to use the
> old reserved names will result in a failure. Specifically, groups lpw0,
> lpw2, lsc1, lsck, and lsda were changed from function rsvd4 to displaya,
> and group pta was changed from function rsvd2 to hdmi.
>
> All boards' pin mux tables needed some edits on top of the based format
> conversion, since function i2c was split into i2c1 (first general I2C
> controller) and i2cp (power I2C controller) to better align function
> definitions with HW blocks.
>
> Due to the split of mux tables into pure mux and pull/tristate tables,
> many entries in the separate Seaboard/Ventana tables could be merged
> into the common table, since the entries differed only in the portion
> in one of the tables, not both.
>
> Most pin groups allow configuration of mux, tri-state, and pull. However,
> some don't allow pull configuration, which is instead configured by new
> groups that only allow pull configuration. This is a reflection of the
> true HW capabilities, which weren't fully represented by the old pinmux
> driver. This required adding new pull table entries for those new groups,
> and setting many other entries' pull configuration to
> TEGRA_PINCONFIG_DONT_SET.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  arch/arm/mach-tegra/board-harmony-pinmux.c   |  362 ++++++++++++++-------
>  arch/arm/mach-tegra/board-paz00-pinmux.c     |  362 ++++++++++++++-------
>  arch/arm/mach-tegra/board-pinmux.c           |   62 ++++-
>  arch/arm/mach-tegra/board-pinmux.h           |   39 ++-
>  arch/arm/mach-tegra/board-seaboard-pinmux.c  |  442 ++++++++++++++++---------
>  arch/arm/mach-tegra/board-trimslice-pinmux.c |  366 ++++++++++++++--------
>  arch/arm/mach-tegra/pinmux.c                 |    6 +-
>  drivers/pinctrl/pinctrl-tegra.c              |    6 +-
>  8 files changed, 1095 insertions(+), 550 deletions(-)

Can I have Colin's or Olof's ACK on this Tegra stuff too?
Would feel better...

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks!
Linus Walleij

  reply	other threads:[~2012-01-24 22:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 18:22 [PATCH 1/4] pinctrl: add a driver for NVIDIA Tegra Stephen Warren
2012-01-20 18:22 ` [PATCH 2/4] ARM: tegra: Select PINCTRL Kconfig variables Stephen Warren
2012-01-24 22:34   ` Linus Walleij
2012-01-20 18:22 ` [PATCH 3/4] ARM: tegra: Switch to new pinctrl driver Stephen Warren
2012-01-24 22:36   ` Linus Walleij [this message]
2012-01-24 22:44     ` Olof Johansson
2012-01-24 23:13       ` Linus Walleij
2012-02-01  8:16         ` Olof Johansson
2012-02-01  8:20     ` Olof Johansson
2012-02-01 20:11       ` Linus Walleij
2012-02-01 21:49         ` Olof Johansson
2012-01-20 18:22 ` [PATCH 4/4] ARM: tegra: Remove pre-pinctrl pinmux driver Stephen Warren
2012-01-24 22:37   ` Linus Walleij
2012-01-24 22:33 ` [PATCH 1/4] pinctrl: add a driver for NVIDIA Tegra Linus Walleij
2012-01-24 23:09   ` Stephen Warren
2012-01-24 23:27     ` Linus Walleij
2012-01-24 23:36       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZ_hBviswq7pXoLozC8gjzvowCBrj9yjw1xJT79b5rtwQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=ccross@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).