From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751189AbdE2MdU (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 May 2017 08:33:20 -0400
Received: from mail-io0-f174.google.com ([209.85.223.174]:36666 "EHLO
        mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750989AbdE2MdR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 May 2017 08:33:17 -0400
MIME-Version: 1.0
In-Reply-To: <7678f5c040c6b578fa008c9b510bb936a218310c.1495814557.git.jan.kiszka@siemens.com>
References: <cover.1495814557.git.jan.kiszka@siemens.com> <7678f5c040c6b578fa008c9b510bb936a218310c.1495814557.git.jan.kiszka@siemens.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Mon, 29 May 2017 14:33:16 +0200
Message-ID: <CACRpkdZeRQdM1RrPzqWnJOFiwbdgiGgzo_cVdMhgp2URriNJLQ@mail.gmail.com>
Subject: Re: [PATCH v3 06/10] gpio: exar: Fix reading of directions and values
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Sascha Weisenberger <sascha.weisenberger@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 26, 2017 at 6:02 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:

> First, the logic for translating a register bit to the return code of
> exar_get_direction and exar_get_value were wrong. And second, there was
> a flip regarding the register bank in exar_get_direction.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij