From: Linus Walleij <linus.walleij@linaro.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Lior Amsalem <alior@marvell.com>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Ben Dooks <ben.dooks@codethink.co.uk>,
Rob Landley <rob@landley.net>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/9] pinctrl: mvebu: pinctrl driver core
Date: Wed, 12 Sep 2012 08:04:57 +0200 [thread overview]
Message-ID: <CACRpkdZf7YO4+aY42JK4OhhTSDCxN+hNjG+xVeyJ7QHsuaqh5A@mail.gmail.com> (raw)
In-Reply-To: <504FB869.60201@wwwdotorg.org>
On Wed, Sep 12, 2012 at 12:17 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> the drivers in this patch seem to invert the data-structures a
> little - in other words, instead of defining a global list of functions,
> they define a list of groups, and for each group, list the functions
> that can be selected on to it.
>
> In turn, that probably requires the core mvebu driver to invert these
> data-structures at run-time in order to provide the data the pinctrl
> core needs. I think it'd be better to just have each SoC-specific driver
> store the data tables in the same format that the pinctrl core needs it,
> so that the mvebu pinctrl core won't have to process the data-structures
> at all.
I sort of agree, not a blocker from my side but it'll surely make the
code easier to maintain.
Else I think the culprit function needs some commenting to be
readable, and writing in plaintext what can be explained by
simpler code is not good...
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-09-12 6:05 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 12:56 [PATCH 00/11] pinctrl: mvebu: pinctrl driver Sebastian Hesselbarth
2012-08-11 12:56 ` [PATCH 01/11] pinctrl: mvebu: pinctrl driver core Sebastian Hesselbarth
2012-08-20 9:09 ` Linus Walleij
2012-08-20 9:46 ` Sebastian Hesselbarth
2012-08-20 12:51 ` Thomas Petazzoni
2012-08-20 14:18 ` Linus Walleij
2012-08-20 14:51 ` Sebastian Hesselbarth
2012-08-25 8:22 ` Andrew Lunn
2012-08-20 14:11 ` Linus Walleij
2012-08-11 12:56 ` [PATCH 02/11] pinctrl: mvebu: dove pinctrl driver Sebastian Hesselbarth
2012-08-20 13:43 ` Linus Walleij
2012-08-20 14:43 ` Sebastian Hesselbarh
2012-08-20 17:16 ` Thomas Petazzoni
2012-08-11 12:56 ` [PATCH 03/11] pinctrl: mvebu: kirkwood " Sebastian Hesselbarth
2012-08-20 13:49 ` Linus Walleij
2012-08-27 13:43 ` Ben Dooks
2012-08-27 19:19 ` Sebastian Hesselbarth
2012-08-27 20:02 ` Stephen Warren
2012-08-11 12:56 ` [PATCH 04/11] pinctrl: mvebu: add pinctrl driver for Armada 370 Sebastian Hesselbarth
2012-08-20 14:25 ` Linus Walleij
2012-08-20 16:48 ` Sebastian Hesselbarth
2012-08-20 17:36 ` Thomas Petazzoni
2012-08-20 18:01 ` Sebastian Hesselbarth
2012-08-20 18:51 ` Thomas Petazzoni
2012-08-21 7:12 ` Gregory CLEMENT
2012-08-11 12:56 ` [PATCH 05/11] pinctrl: mvebu: add pinctrl driver for Armada XP Sebastian Hesselbarth
2012-08-20 14:26 ` Linus Walleij
2012-08-11 12:56 ` [PATCH 06/11] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs Sebastian Hesselbarth
2012-08-20 14:27 ` Linus Walleij
2012-08-11 12:56 ` [PATCH 07/11] ARM: mvebu: Add pinctrl support to Armada XP SoCs Sebastian Hesselbarth
2012-08-20 14:27 ` Linus Walleij
2012-08-11 12:56 ` [PATCH 08/11] ARM: mvebu: Add pinctrl support to Armada 370 SoC Sebastian Hesselbarth
2012-08-20 14:28 ` Linus Walleij
2012-08-11 12:56 ` [PATCH 09/11] ARM: mvebu: adjust Armada XP evaluation board DTS Sebastian Hesselbarth
2012-08-20 14:28 ` Linus Walleij
2012-08-11 12:56 ` [PATCH 10/11] arm: mvebu: enable PINCTRL usage Sebastian Hesselbarth
2012-08-20 14:29 ` Linus Walleij
2012-08-11 12:56 ` [PATCH 11/11] arm: mvebu: add pinctrl support in defconfig Sebastian Hesselbarth
2012-08-20 14:31 ` Linus Walleij
2012-08-20 14:54 ` Sebastian Hesselbarth
2012-08-20 17:37 ` Thomas Petazzoni
2012-08-20 8:12 ` [PATCH 00/11] pinctrl: mvebu: pinctrl driver Linus Walleij
2012-08-22 8:22 ` [PATCH v2 0/9] " Sebastian Hesselbarth
2012-08-22 8:22 ` [PATCH v2 1/9] pinctrl: mvebu: pinctrl driver core Sebastian Hesselbarth
2012-08-22 20:43 ` Stephen Warren
2012-08-23 9:45 ` Sebastian Hesselbarth
2012-08-23 17:54 ` Stephen Warren
2012-08-23 20:31 ` Sebastian Hesselbarth
2012-08-23 21:26 ` Stephen Warren
2012-08-23 23:01 ` Sebastian Hesselbarth
2012-08-24 3:34 ` Stephen Warren
2012-08-25 15:53 ` Sebastian Hesselbarth
2012-08-27 4:33 ` Stephen Warren
2012-09-02 7:30 ` Linus Walleij
2012-09-02 8:27 ` Sebastian Hesselbarth
2012-09-03 9:32 ` Linus Walleij
2012-09-03 19:47 ` Jason Cooper
2012-09-09 19:56 ` Jason Cooper
2012-08-22 8:22 ` [PATCH v2 2/9] pinctrl: mvebu: dove pinctrl driver Sebastian Hesselbarth
2012-08-22 8:22 ` [PATCH v2 3/9] pinctrl: mvebu: kirkwood " Sebastian Hesselbarth
2012-08-22 8:22 ` [PATCH v2 4/9] pinctrl: mvebu: add pinctrl driver for Armada 370 Sebastian Hesselbarth
2012-08-22 8:22 ` [PATCH v2 5/9] pinctrl: mvebu: add pinctrl driver for Armada XP Sebastian Hesselbarth
2012-08-22 8:22 ` [PATCH v2 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs Sebastian Hesselbarth
2012-08-22 8:22 ` [PATCH v2 7/9] ARM: mvebu: Add pinctrl support to Armada XP SoCs Sebastian Hesselbarth
2012-08-22 20:45 ` Stephen Warren
2012-08-22 8:22 ` [PATCH v2 8/9] ARM: mvebu: Add pinctrl support to Armada 370 SoC Sebastian Hesselbarth
2012-08-22 20:46 ` Stephen Warren
2012-08-22 8:22 ` [PATCH v2 9/9] ARM: mvebu: adjust Armada XP evaluation board DTS Sebastian Hesselbarth
2012-09-10 8:39 ` [PATCH v3 0/9] pinctrl: mvebu: pinctrl driver Sebastian Hesselbarth
2012-09-10 8:39 ` [PATCH v3 1/9] pinctrl: mvebu: pinctrl driver core Sebastian Hesselbarth
2012-09-10 15:39 ` Linus Walleij
2012-09-11 14:44 ` Thomas Petazzoni
2012-09-11 22:17 ` Stephen Warren
2012-09-12 6:04 ` Linus Walleij [this message]
2012-09-12 6:54 ` Thomas Petazzoni
2012-09-12 15:50 ` Linus Walleij
2012-09-12 16:01 ` Thomas Petazzoni
2012-09-12 16:17 ` Linus Walleij
2012-09-12 21:10 ` Stephen Warren
2012-09-10 8:39 ` [PATCH v3 2/9] pinctrl: mvebu: dove pinctrl driver Sebastian Hesselbarth
2012-09-10 15:40 ` Linus Walleij
2012-09-11 22:18 ` Stephen Warren
2012-09-10 8:39 ` [PATCH v3 3/9] pinctrl: mvebu: kirkwood " Sebastian Hesselbarth
2012-09-10 15:42 ` Linus Walleij
2012-09-10 8:39 ` [PATCH v3 4/9] pinctrl: mvebu: add pinctrl driver for Armada 370 Sebastian Hesselbarth
2012-09-10 15:43 ` Linus Walleij
2012-09-10 8:39 ` [PATCH v3 5/9] pinctrl: mvebu: add pinctrl driver for Armada XP Sebastian Hesselbarth
2012-09-10 15:43 ` Linus Walleij
2012-09-10 8:39 ` [PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs Sebastian Hesselbarth
2012-09-11 22:23 ` Stephen Warren
2012-09-12 6:56 ` Thomas Petazzoni
2012-09-12 20:57 ` Stephen Warren
2012-09-10 8:39 ` [PATCH v3 7/9] ARM: mvebu: Add pinctrl support to Armada XP SoCs Sebastian Hesselbarth
2012-09-10 8:39 ` [PATCH v3 8/9] ARM: mvebu: Add pinctrl support to Armada 370 SoC Sebastian Hesselbarth
2012-09-10 8:39 ` [PATCH v3 9/9] ARM: mvebu: adjust Armada XP evaluation board DTS Sebastian Hesselbarth
2012-09-10 15:45 ` [PATCH v3 0/9] pinctrl: mvebu: pinctrl driver Linus Walleij
2012-09-10 15:57 ` Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 00/10] " Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 01/10] pinctrl: mvebu: pinctrl driver core Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 02/10] pinctrl: mvebu: dove pinctrl driver Sebastian Hesselbarth
2013-06-18 11:36 ` Russell King - ARM Linux
2013-06-18 12:01 ` Sebastian Hesselbarth
2013-06-18 15:02 ` Linus Walleij
2013-06-18 15:11 ` Russell King - ARM Linux
2013-06-18 15:23 ` Linus Walleij
2013-06-18 18:33 ` Mark Brown
2012-09-13 15:41 ` [PATCH v4 03/10] pinctrl: mvebu: kirkwood " Sebastian Hesselbarth
2012-09-16 7:46 ` Andrew Lunn
2012-09-16 9:09 ` Sebastian Hesselbarth
2012-09-17 8:45 ` Linus Walleij
2012-09-20 15:30 ` Arnd Bergmann
2012-09-20 18:34 ` Andrew Lunn
2012-09-20 19:28 ` Linus Walleij
2012-09-20 19:36 ` Thomas Petazzoni
2012-09-20 19:51 ` Andrew Lunn
2012-09-21 10:56 ` Ben Dooks
2012-09-21 18:14 ` Linus Walleij
2012-09-16 12:40 ` Jason Cooper
2012-09-17 1:55 ` Nicolas Pitre
2012-09-17 6:36 ` Sebastian Hesselbarth
2012-09-17 8:32 ` Andrew Lunn
2012-09-18 18:59 ` Andrew Lunn
2012-09-13 15:41 ` [PATCH v4 04/10] pinctrl: mvebu: add pinctrl driver for Armada 370 Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 05/10] pinctrl: mvebu: add pinctrl driver for Armada XP Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 06/10] ARM: mvebu: Add pinctrl support to Armada XP SoCs Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 07/10] ARM: mvebu: Add pinctrl support to Armada 370 SoC Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 08/10] ARM: mvebu: adjust Armada XP evaluation board DTS Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 09/10] arm: mvebu: split Kconfig options for Armada 370 and XP Sebastian Hesselbarth
2012-09-13 15:41 ` [PATCH v4 10/10] arm: mvebu: select the pinctrl drivers for Armada 370 and Armada XP platforms Sebastian Hesselbarth
2012-09-13 15:48 ` [PATCH v4 00/10] pinctrl: mvebu: pinctrl driver Thomas Petazzoni
2012-09-14 16:41 ` Stephen Warren
2012-09-20 8:13 ` [PATCH 00/11] " Linus Walleij
2012-09-20 8:17 ` Sebastian Hesselbarth
2012-09-20 9:04 ` Thomas Petazzoni
2012-09-20 10:02 ` Andrew Lunn
2012-09-20 10:32 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZf7YO4+aY42JK4OhhTSDCxN+hNjG+xVeyJ7QHsuaqh5A@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sebastian.hesselbarth@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).