From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161396AbcFBOgh (ORCPT ); Thu, 2 Jun 2016 10:36:37 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:33683 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161356AbcFBOgT (ORCPT ); Thu, 2 Jun 2016 10:36:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <3d90f889782a9c8380c3694e55a135ddd6de9bc4.1463164919.git.leonard.crestez@intel.com> <6c5cc47895ca35fce84b6b01a3ecf7df928aa197.1463164919.git.leonard.crestez@intel.com> <821accfa-33fc-9d64-2601-7feae77bf38a@intel.com> Date: Thu, 2 Jun 2016 16:36:18 +0200 Message-ID: Subject: Re: [PATCH 3/3] iio: st_sensors: Use level interrupts From: Linus Walleij To: Jonathan Cameron Cc: Crestez Dan Leonard , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Daniel Baluta , Giuseppe Barba , Denis Ciocca Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 29, 2016 at 9:29 PM, Jonathan Cameron wrote: > On 24/05/16 13:35, Crestez Dan Leonard wrote: >> This might be completely crazy, but wouldn't it be possible to support >> gpio level interrupts purely in software? Just read the GPIO state again >> after the interrupt is unmasked and retrigger. >> >> This seems preferable to implementing per-driver workarounds. Perhaps it >> would even fit in some gpio-irqchip glue. > > That's precisely the question I raised way back when writing the lis3l02dq > driver. Apparently someone once had a go but it never went anywhere... It is maybe possible to do in some cases. What you have to do is to augment the GPIO irqchip driver to read the line status register after handling an IRQ, if level IRQ is desired, and if the line is still high after a rising edge or still low after a falling edge, just call the IRQ handler again. This will not work with threaded interrupt handlers, because that code is in the "hard" path of the interrupt handling code, that gets executed in response to an IRQ signal. What it would take is code to go back into the "hard" irq handler after the thread has run, and take a second lap in checking the line levels. I don't know if that is possible to achieve in Linux, hm :/ Yours, Linus Walleij