From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1326AC6FD1D for ; Thu, 23 Mar 2023 08:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbjCWIRX (ORCPT ); Thu, 23 Mar 2023 04:17:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbjCWIRT (ORCPT ); Thu, 23 Mar 2023 04:17:19 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 921352F7BF for ; Thu, 23 Mar 2023 01:17:18 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-544f7c176easo237858137b3.9 for ; Thu, 23 Mar 2023 01:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679559438; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HdKzKGBqE2UzdYM8uwBYXrywRu/Xybckfy7Y+++wr10=; b=NI9FOTYwvRfNRNSGZO17tdlW0rywguZRWtOe5U0p1MyeA4adXKyL463IGDS6IXPQmr HQUA/Qg97P/BDnqqPNss7DxhUbUPdufgO84cWbnaxJA3hjb92FZCamWf8q0ZjhtNdbKW 0ni8Y6x7pC/n4yqYBm5aH7zXfW780Xz95sMl/edpuzI7u+dNcCH7HfhcpVQJmSg3pHHp Gl5T1UPjivdexU/c39SW8cKeFpBy78SZt6LBiQj7UFQ2hySeotJjnbmdw8B4QtVr14CV 2Wtt/bBKYvsEIBqGsc1LhYRZrHTOc6G+u6NEeBgbLIZ+JqhWuILKVuJ2DRZNy8r4htf5 5tUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679559438; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HdKzKGBqE2UzdYM8uwBYXrywRu/Xybckfy7Y+++wr10=; b=eWRiZhRRJU4/e3GHkPKit3FX0un2S4a8orpOF3kKFvY+JKBkjUF6a0djcedyv4LV9H Vofff1SEmCpOL6zqG1Z1cAsagq1HoBkG4g3kQ5bhNdk0STqYwaaICz6pvIvTiwV9jgMB qJ8Wa220ldUJ//NPKmzi8uUsJmF6z8v6jjzioYW+PxSnSlUobP2zEO10UI2L9LvB6+mP ehSe4H9Gbl55WKstbn3rSj59BmxxQUHONQIZVeuj43k/t1KQKjnQqJfqaCQrMtJZf+LG sXg5YQEjsMg1183JToJdL+iwCNHHEarmSMwbIZ6PL3ucm/mXarwEVcs4qUo97haeVEIt z+YQ== X-Gm-Message-State: AAQBX9d+rJCTHgzr2+njRQ09FlGKBSJ5JmJDBPRr8eidwO2iwjnk/Le7 hCgYoHz6a2qhXl1K3JRWCwoa25H7cU4XUzwNJiYm7XQSTImcUONm X-Google-Smtp-Source: AKy350YN+CgPSFTzKICPcWLKCZQ/uzwmk8idwB+0RhLSoiZKkqryk6nDE6EkOkBhOk2uJfA/eIaf3j6XEgT4M1GvXT0= X-Received: by 2002:a81:ed09:0:b0:534:d71f:14e6 with SMTP id k9-20020a81ed09000000b00534d71f14e6mr1243394ywm.9.1679559437818; Thu, 23 Mar 2023 01:17:17 -0700 (PDT) MIME-Version: 1.0 References: <20230321135412.73240-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230321135412.73240-1-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Thu, 23 Mar 2023 09:17:06 +0100 Message-ID: Subject: Re: [PATCH v1 1/2] gpiolib: Replace open coded krealloc() To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 2:53=E2=80=AFPM Andy Shevchenko wrote: > gpiod_get_array() does a new allocation in some cases, followed > by copying previously allocated placeholder for the descriptors. > > Replace that with krealloc(__GFP_ZERO), since it was kzalloc() > originally. > > Signed-off-by: Andy Shevchenko Wow that's a really nice patch! Reviewed-by: Linus Walleij Yours, Linus Walleij