From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbcFNG4y (ORCPT ); Tue, 14 Jun 2016 02:56:54 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:34563 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbcFNG4w (ORCPT ); Tue, 14 Jun 2016 02:56:52 -0400 MIME-Version: 1.0 In-Reply-To: <1465831250-2689101-2-git-send-email-arnd@arndb.de> References: <1465831250-2689101-1-git-send-email-arnd@arndb.de> <1465831250-2689101-2-git-send-email-arnd@arndb.de> From: Linus Walleij Date: Tue, 14 Jun 2016 08:56:51 +0200 Message-ID: Subject: Re: [PATCH 2/2] pinctrl: max77620: select PINMUX To: Arnd Bergmann Cc: Laxman Dewangan , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2016 at 5:18 PM, Arnd Bergmann wrote: > The recently added max77620 driver fails to build when CONFIG_PINMUX > is not set: > > pinctrl/pinctrl-max77620.c:272:21: error: variable 'max77620_pinmux_ops' has initializer but incomplete type > static const struct pinmux_ops max77620_pinmux_ops = { > ^~~~~~~~~~ > pinctrl/pinctrl-max77620.c:273:2: error: unknown field 'get_functions_count' specified in initializer > > This adds the Kconfig 'select' statement that was clearly meant > to be there and is used in all other pinmux drivers. > > Signed-off-by: Arnd Bergmann Patch applied. Yours, Linus Walleij