From: Linus Walleij <linus.walleij@linaro.org>
To: Nandor Han <nandor.han@ge.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] doc,dts - add XRA1403 DTS binding documentation
Date: Wed, 29 Mar 2017 04:09:38 +0200 [thread overview]
Message-ID: <CACRpkdZkuPKnz=5qqfNyj-JJQV7i_8e2X3-Scd13eowBrVvDqw@mail.gmail.com> (raw)
In-Reply-To: <39ba92bacf48da957f8f85d5cb11d3254fe3d68f.1490595641.git.nandor.han@ge.com>
On Mon, Mar 27, 2017 at 8:23 AM, Nandor Han <nandor.han@ge.com> wrote:
> Add the XRA1403 DTS binding documentation.
>
> Signed-off-by: Nandor Han <nandor.han@ge.com>
There is no big problem with this but:
> +The XRA1403 is an 16-bit GPIO expander with an SPI interface. Features available:
> + - Individually programmable inputs:
> + - Internal pull-up resistors
> + - Polarity inversion
> + - Individual interrupt enable
> + - Rising edge and/or Falling edge interrupt
> + - Input filter
Since you mention that it has interrupts maybe you want to add bindings
for the cascaded interrupt and the interrupt-controller; keyword etc
already now.
We just document what the hardware can do, we don't have to do all
of it in the first Linux driver submission.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-03-29 2:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 6:22 [PATCH 0/3] XRA1403,gpio - add XRA1403 gpio expander driver Nandor Han
2017-03-27 6:23 ` [PATCH 1/3] gpio - Add EXAR XRA1403 SPI GPIO " Nandor Han
2017-03-29 2:07 ` Linus Walleij
2017-04-05 13:24 ` Han, Nandor (GE Healthcare)
2017-04-07 10:07 ` Linus Walleij
2017-04-08 7:38 ` Han, Nandor (GE Healthcare)
2017-03-31 12:38 ` Rob Herring
2017-03-27 6:23 ` [PATCH 2/3] doc,dts - add XRA1403 DTS binding documentation Nandor Han
2017-03-29 2:09 ` Linus Walleij [this message]
2017-03-31 18:49 ` Rob Herring
2017-03-27 6:23 ` [PATCH 3/3] Add XRA1403 support to MAINTAINERS file Nandor Han
2017-03-29 1:50 ` [PATCH 0/3] XRA1403,gpio - add XRA1403 gpio expander driver Linus Walleij
2017-04-05 12:46 ` Han, Nandor (GE Healthcare)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZkuPKnz=5qqfNyj-JJQV7i_8e2X3-Scd13eowBrVvDqw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nandor.han@ge.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).