From: Linus Walleij <linus.walleij@linaro.org>
To: Kent Gibson <warthog618@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Hector Bujanda <hector.bujanda@digi.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: add GPIO_SET_DEBOUNCE_IOCTL
Date: Wed, 27 May 2020 07:31:20 +0200 [thread overview]
Message-ID: <CACRpkdZnLv=mv6JEHx0aF8YsUbpJH_ZrtCD+T23XfqvJLxw4Xg@mail.gmail.com> (raw)
In-Reply-To: <20200525151736.GA32461@sol>
On Mon, May 25, 2020 at 5:17 PM Kent Gibson <warthog618@gmail.com> wrote:
> > I suppose gpiolib would have to steal or intercept the interrupt
> > by using e.g. IRQF_SHARED and then just return IRQ_HANDLED
> > on the first IRQ so the underlying irq handler does not get called.
>
> And how would gpiolib ensure that it was first in the chain?
I don't know.
> Totally agree with the concept - just trying to work out how to
> implement it seemlessly given the existing API and usage, and given my
> limited knowledge of the kernel internals.
The irqchip maintainers certainly know the answer for the question
of shared interrupts at least.
> > Failure is an option! Sorry if I push too complex ideas.
>
> I'm not as concerned about complexity as I am about fragility.
>
> I don't see any problem adding debounce for gpiolib-cdev.
> Adding a more complete solution to gpiolib itself is certainly
> non-trivial, if it is possible at all.
I agree. It's just that I perceive it as more elegant if we can do that.
> The path I'll probably be taking is adding a debouncer to gpiolib-cdev,
> so at least we have a solution for userspace, then take a longer look at
> the more general solution.
That's fine! Thanks for looking into this.
Linus Walleij
next prev parent reply other threads:[~2020-05-27 5:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 0:18 [PATCH] gpiolib: add GPIO_SET_DEBOUNCE_IOCTL Hector Bujanda
2020-04-29 12:06 ` Bartosz Golaszewski
2020-04-29 12:38 ` Linus Walleij
2020-04-29 12:59 ` Bartosz Golaszewski
2020-04-30 13:32 ` Bujanda, Hector
2020-04-30 14:58 ` Kent Gibson
2020-05-04 10:31 ` Bartosz Golaszewski
2020-05-07 3:39 ` Kent Gibson
2020-05-14 14:21 ` Linus Walleij
2020-05-12 17:55 ` Linus Walleij
2020-05-13 4:33 ` Kent Gibson
2020-05-25 2:22 ` Kent Gibson
2020-05-25 12:17 ` Linus Walleij
2020-05-25 15:17 ` Kent Gibson
2020-05-27 5:31 ` Linus Walleij [this message]
2020-05-04 12:37 ` Andy Shevchenko
2020-04-19 0:22 Hector Bujanda
2020-04-28 10:35 ` Linus Walleij
2020-04-29 1:49 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZnLv=mv6JEHx0aF8YsUbpJH_ZrtCD+T23XfqvJLxw4Xg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=brgl@bgdev.pl \
--cc=hector.bujanda@digi.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).