From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B468C43219 for ; Sun, 1 May 2022 21:45:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358144AbiEAVsv (ORCPT ); Sun, 1 May 2022 17:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355448AbiEAVsq (ORCPT ); Sun, 1 May 2022 17:48:46 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31CD10D2 for ; Sun, 1 May 2022 14:45:18 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id y2so23310837ybi.7 for ; Sun, 01 May 2022 14:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=jIUUFw/Dk0bJvSpV2KhChXMwtNlLYqsYYK4oY1ZrIaM5CwokwxvKI2nY/2x/UYhhSZ cnYvPcNR4I1+2mQEXOx+fTBIepxbMOgfBDYzGHDeV47Jl9VtWIb/nS+yTlzYid021q5y 4rk1aenFHUTcFpOe8yZyA6PrfG7AdYTLzyJZCxoXrUBdmiOH7kD+EpptUWvO22jzMcIN xSCS+MFyhpSsWhXxvfUnHSHIueURSlmIpP3ceYNATHQiGd7mRdyumFBzg7HidVpGXR/K HmLBNFjobzv+Lfi/mc0Jdu1mADUOwm6Q+P8Sv4LOYfSplf9TRRKfiG/zS7FqqwYnszNe 9g7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=0WrR82SfiTaWe68S51IxdTc7Bbp8mm88O0IEaZFvS0Kd+3jjwnxFU8TftEphONxBcl 6UeFNyD6SzmzW83g4KtKfa2mTiqusU7pXsMs/AGmk5yFFpXp+3KXOA1hb0+9gJhwSZZo 6ROUYWy+a6dVBLr7eFhXbo0b+ahZmhY4v/8vrbBDwkH+rIs0k/6Kf4tDoipDWSUmvDyc UkkRdC6O3tWRotUxFk2RUoZKXPFOsRr01qGuovLf6J8sOgULOVtYNVu2odArcqSVWs4v 19diJiRgW4/zWJJhgDnruF/wP+58n3d23e58nnDfpF1yuLxy+z5uVGLcozCbJ8Ez1Gxo FH1g== X-Gm-Message-State: AOAM533XrgRj5xXpC2E4G200s2r4YAkFlOULIx9yyl7lOq7wFe2wGDVi xla9V10c8nSkhIIqfJ4tj0MzrTkS/xai09X3dJTc8Q== X-Google-Smtp-Source: ABdhPJz9eJE7cneK+kxH13EYMup9tW/2JAXx6cXKgLkzm/eVQ61nD3w0biIeuzEawWWGZ8vTkmgdM3jCm2iwQFey2JY= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr8658475ybh.369.1651441518148; Sun, 01 May 2022 14:45:18 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-22-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-22-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:45:06 +0200 Message-ID: Subject: Re: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The three eseries machines have very similar drivers for audio, all > using the mach/eseries-gpio.h header for finding the gpio numbers. > > Change these to use gpio descriptors to avoid the header file > dependency. > > I convert the _OFF gpio numbers into GPIO_ACTIVE_LOW ones for > consistency here. > > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Nice use of active low. Maybe I would simply have dropped the _OFF suffix on these GPIO lines as it can be confusing now that their active level is encoded but no big deal. Reviewed-by: Linus Walleij Yours, Linus Walleij