From: Linus Walleij <linus.walleij@linaro.org>
To: Andrei.Stefanescu@microchip.com
Cc: Greg KH <gregkh@linuxfoundation.org>,
Nicolas Ferre <Nicolas.Ferre@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ludovic Desroches <Ludovic.Desroches@microchip.com>,
Cristian.Birsan@microchip.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: gpio: add sama5d2 PIOBU support
Date: Thu, 15 Nov 2018 10:43:05 +0100 [thread overview]
Message-ID: <CACRpkdZvJmH61C8Rd3TeTioag+11GHPGdCDwRHxx3UAzB-rUHg@mail.gmail.com> (raw)
In-Reply-To: <1541603580-17448-2-git-send-email-andrei.stefanescu@microchip.com>
On Wed, Nov 7, 2018 at 4:12 PM <Andrei.Stefanescu@microchip.com> wrote:
> +Required properties:
> +- compatible: "syscon", "microchip,sama5d2-piobu"
Looks like "syscon" should be dropped, it is using a syscon,
but it is no syscon.
> + secumod@fc040000 {
> + compatible = "syscon", "microchip,sama5d2-piobu";
> + reg = <0xfc040000 0x100>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
Isn't it easiest to just make this driver be a subnode of the
syscon so it can just refer to its parent to find the
syscon it needs?
Just state that in the bindings and make an example where
it is inside the syscon.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-11-15 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 15:12 [PATCH 0/3] add sama5d2 PIOBU GPIO driver Andrei.Stefanescu
2018-11-07 15:12 ` [PATCH 1/3] dt-bindings: gpio: add sama5d2 PIOBU support Andrei.Stefanescu
2018-11-15 9:43 ` Linus Walleij [this message]
2018-11-07 15:12 ` [PATCH 2/3] MAINTAINERS: add maintainer for sama5d2 PIOBU GPIO driver Andrei.Stefanescu
2018-11-15 9:40 ` Linus Walleij
2018-11-07 15:12 ` [PATCH 3/3] gpio: add driver for sama5d2 PIOBU pins Andrei.Stefanescu
2018-11-15 9:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZvJmH61C8Rd3TeTioag+11GHPGdCDwRHxx3UAzB-rUHg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Andrei.Stefanescu@microchip.com \
--cc=Cristian.Birsan@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).