From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932398AbcKHIra (ORCPT ); Tue, 8 Nov 2016 03:47:30 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:36339 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932318AbcKHIrY (ORCPT ); Tue, 8 Nov 2016 03:47:24 -0500 MIME-Version: 1.0 In-Reply-To: <1478537603-23653-14-git-send-email-andrew.smirnov@gmail.com> References: <1478537603-23653-1-git-send-email-andrew.smirnov@gmail.com> <1478537603-23653-14-git-send-email-andrew.smirnov@gmail.com> From: Linus Walleij Date: Tue, 8 Nov 2016 09:47:23 +0100 Message-ID: Subject: Re: [PATCH v2 13/15] pinctrl-sx150x: Use handle_bad_irq instead of handle_edge_irq To: Andrey Smirnov Cc: "linux-gpio@vger.kernel.org" , Neil Armstrong , "linux-kernel@vger.kernel.org" , Chris Healy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 7, 2016 at 5:53 PM, Andrey Smirnov wrote: > Althought the function passed as a "handler" during GPIO chip > instantiation is not going to ever be called, specifying handle_edge_irq > there makes for a rather confusing read, both because no "ack" callback > in specified for irqchip and because there's no acking action is > necessary. > > Specify handle_bad_irq instead a make a note of the situation. This > commit should be a no-op behaviour wise. > > Tested-by: Neil Armstrong > Acked-by: Neil Armstrong > Signed-off-by: Andrey Smirnov Patch applied! Yours, Linus Walleij