archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <>
To: Manivannan Sadhasivam <>
Cc: "open list:GPIO SUBSYSTEM" <>,
	"" <>
Subject: Re: [PATCH] gpio: pl061: Move irq_chip definition inside struct pl061
Date: Wed, 31 Oct 2018 11:33:24 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Oct 24, 2018 at 7:29 PM Manivannan Sadhasivam
<> wrote:

> Keeping the irq_chip definition static will make it shared with multiple
> giochips in the system. This practice is considered to be bad and now we
> will get the below warning from gpiolib core:
> "detected irqchip that is shared with multiple gpiochips: please fix the
> driver."
> Hence, move the irq_chip definition from static to `struct pl061` for
> using a unique irq_chip for each gpiochip.
> Signed-off-by: Manivannan Sadhasivam <>

Patch applied. Much better like this!

Linus Walleij

      reply	other threads:[~2018-10-31 10:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 17:29 Manivannan Sadhasivam
2018-10-31 10:33 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] gpio: pl061: Move irq_chip definition inside struct pl061' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).