From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63C02C0044C for ; Wed, 31 Oct 2018 10:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D6AA2081B for ; Wed, 31 Oct 2018 10:33:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="dp4ih71h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D6AA2081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728568AbeJaTbK (ORCPT ); Wed, 31 Oct 2018 15:31:10 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:38530 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727852AbeJaTbK (ORCPT ); Wed, 31 Oct 2018 15:31:10 -0400 Received: by mail-lf1-f65.google.com with SMTP id p86so9020522lfg.5 for ; Wed, 31 Oct 2018 03:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+j/8UB3xi60tEslBHhsP1eRrpIUFOumqGmZehb45eLw=; b=dp4ih71hvujbuxaqRlbVRdRYJ/l0cPTxJj1e9w8bJ0FElWgmgsVGYMIOgYrNKgT4AI oGjecNW6jU9gG/N66xaJwlyewUd99E5Dg1PQK3bVavgY+lP0p0VBkxRWeq3r/lZtvIv7 PL0RqoYL4cHBbYIvEX5gtUABBgSwQQbc6qGNc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+j/8UB3xi60tEslBHhsP1eRrpIUFOumqGmZehb45eLw=; b=qcCW+r4Y9tMTEl1QBcYe0N1pkhiSFWmOMn172/G9cb5AtmktCwmcoErpry7RfEzLJx UHo+roa69cnejozxhQyuyej3QtnWhMwvHmwPiK1mv+IM6UHuqInLurSi0QGduFtWgrFv HiiWj/YqauTwPDNDz7+7ZKkD7C/j3iQxuxIhYqj8snYp4b3yu3kbE+LEgKpcNYaPLedw GDmHwji2KTMy7jdQ+jyWY9I5MoyqOwa6abBgLUVyiOCbcOdejZwTdHgJ1kT0Bj255Lzp jL9pfs9uBvnJRyGLZyoaS07hO306jI6vslpPT8Wz0HqgmRptXHKe+zJWJGQgxMUSIh0J YB9w== X-Gm-Message-State: AGRZ1gKZsHBQaZJ4IZIU4JwprXhb2S5r5TgSPlyOkuZxqFojH2grf6Gl cIhcMXCf47LI4M5f5fMUMKYk2PTFnj6qFV7KHc0uvw== X-Google-Smtp-Source: AJdET5d2/79CaP8/PDW3wgqRSI66pKMI4hh35KdZe3u9BVq2fkOsqpUdVhCDzl+o0wSFOKlg1ZTj3gfWKv86+qTMzi4= X-Received: by 2002:a19:2752:: with SMTP id n79mr1586542lfn.11.1540982016314; Wed, 31 Oct 2018 03:33:36 -0700 (PDT) MIME-Version: 1.0 References: <20181024172915.15544-1-manivannan.sadhasivam@linaro.org> In-Reply-To: <20181024172915.15544-1-manivannan.sadhasivam@linaro.org> From: Linus Walleij Date: Wed, 31 Oct 2018 11:33:24 +0100 Message-ID: Subject: Re: [PATCH] gpio: pl061: Move irq_chip definition inside struct pl061 To: Manivannan Sadhasivam Cc: "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 24, 2018 at 7:29 PM Manivannan Sadhasivam wrote: > Keeping the irq_chip definition static will make it shared with multiple > giochips in the system. This practice is considered to be bad and now we > will get the below warning from gpiolib core: > > "detected irqchip that is shared with multiple gpiochips: please fix the > driver." > > Hence, move the irq_chip definition from static to `struct pl061` for > using a unique irq_chip for each gpiochip. > > Signed-off-by: Manivannan Sadhasivam Patch applied. Much better like this! Yours, Linus Walleij