From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61C0C433DB for ; Mon, 1 Mar 2021 14:57:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89CA264DAF for ; Mon, 1 Mar 2021 14:57:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236529AbhCAO5O (ORCPT ); Mon, 1 Mar 2021 09:57:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236717AbhCAO4W (ORCPT ); Mon, 1 Mar 2021 09:56:22 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C138DC06178C for ; Mon, 1 Mar 2021 06:55:41 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id p15so10817773ljc.13 for ; Mon, 01 Mar 2021 06:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tnpOO1HCMDXpZVJ4TRrGsHFf+M4ik5c2oeXAvl9URfQ=; b=FtuktIcgFjkP+lffETe2dQRR3faqxThx7Z+FrZdfTNEpjy2/6i+IwQQbWERlk1QYDB cGoAjzqc4grAlmEK4OMTydKLzH/YOZaHwJeB6/fv7VTqhI3rnmkw74olFgXvHhZd58Uo 7Ycqofp8NnLYI0Zg7o2jGUW+YaxMnjQWxO0G8D5Krx2St2mWlOTCvEwicGwbYEwGeLSo kr9tnf2vSqke3OimzUbHMNpiudVKZK5w2xpozmOJWR3vOhfqclNiiIXeNI9mFBf1Y+pe sFM7G/Fa0gN8m/8Ru5Hc12D00IiWQMPj5LF3CUoCOTn5e2tMT7OrRnwXJ1O+Me72g7Oq Pmog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tnpOO1HCMDXpZVJ4TRrGsHFf+M4ik5c2oeXAvl9URfQ=; b=JyAEjqPr3O2cU0GJnCZG8myLG4InosqhWHt9k2/28c41f3PjLKbM3MQNCby2pBkowr SSre1m5BfVgZ7xfZhG/c9w5Cr1ji/q4ESY/FnKWskWMwufTmPYlcaqb//sqj7c+3SxAF LoEoraun/dsaZf3Se8d3ZL7oVrYVvzK9dH7PZiUgHVTjuq4jDXfpwXNcdkzu6XGYOvU+ 2ZWAMwVqiFMB5I46YimtzlayqbWGz6W8koslPRpvidFDiqhrPQBc0QIaVckils05znLb w29xLpDaNDa256GOZZb8k5Wp88yR7JfUl1OhYxJM+oR0Qqp6u+AOZrpi7eh8f3V55ydS niPw== X-Gm-Message-State: AOAM531Z1vReYZoCA8i82Fq1mf+gmiQ7rpf/mMQtIqrggYW18xnTHZRq 2qOJQdOzwsH1j8m3SpEvZbYIwr4Wkk/yUt0Q/LxTWw== X-Google-Smtp-Source: ABdhPJybRja+1CiW+Qxg0/bCEGHOEl3HR72OhOAPLa0QQOfFepT/r7JpGuivG2pp66Ua3QULP2Q8zfRzX1u/sJEvmJA= X-Received: by 2002:a2e:9754:: with SMTP id f20mr7184365ljj.200.1614610540264; Mon, 01 Mar 2021 06:55:40 -0800 (PST) MIME-Version: 1.0 References: <20210208222203.22335-1-info@metux.net> <20210208222203.22335-13-info@metux.net> In-Reply-To: <20210208222203.22335-13-info@metux.net> From: Linus Walleij Date: Mon, 1 Mar 2021 15:55:29 +0100 Message-ID: Subject: Re: [RFC PATCH 12/12] platform/x86/of: add support for PC Engines APU v2/3/4 boards To: "Enrico Weigelt, metux IT consult" Cc: "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" , Bartosz Golaszewski , Rob Herring , Frank Rowand , Pantelis Antoniou , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 8, 2021 at 11:22 PM Enrico Weigelt, metux IT consult wrote: > + gpio-regs = < > + AMD_FCH_GPIO_REG_GPIO57 // led1 > + AMD_FCH_GPIO_REG_GPIO58 // led2 > + AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 // led3 > + AMD_FCH_GPIO_REG_GPIO32_GE1 // modesw > + AMD_FCH_GPIO_REG_GPIO33_GE2 // simawap > + AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 // mpcie2 > + AMD_FCH_GPIO_REG_GPIO51 // mpcie3 > + >; Please don't define registers in the DTS files. Determine the set of registers from the compatible string and put them in the driver. If that is not possible, the compatible string is not precise enough and needs to indicate properly which hardware this is. Yours, Linus Walleij