From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F42FC32751 for ; Wed, 7 Aug 2019 13:11:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5CFA21E6B for ; Wed, 7 Aug 2019 13:11:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HPW34rTv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388142AbfHGNLo (ORCPT ); Wed, 7 Aug 2019 09:11:44 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35860 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388038AbfHGNLn (ORCPT ); Wed, 7 Aug 2019 09:11:43 -0400 Received: by mail-lj1-f195.google.com with SMTP id i21so6182322ljj.3 for ; Wed, 07 Aug 2019 06:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NqX/zsugDIFGqU1o5bPg+mfxcpflibTDWwvc6+6Rsf8=; b=HPW34rTvAIhdr9bJvlw2XRGRZ+4vv2vK2kKpLqe50l++3Xb1jjvEwDt61lJZuHxXw1 Kngs8VEqnx5a4NESoMrYXBT1gnwRvuoeYwNPC5wSwRxId8ONoHhKNyM4uVcoT2Xh23Lw +0QCWafH2nIKIV09orsewO1F2Zx100X81YxAeJ4/8uFD6ZZs2RyvsHFxjloI1mQtiT2W oCyoH7vXeSNmBSceJyFzetyeKiZFuUC+/I7qKo3IvT+und7w9ERjw9vbvA5iBFS1aL74 CgnaYx19HChPZEnn11I2xV1W3npYhAbTelac6vXLcc0xgJjlFhxuvztC7YAdp5EzLxTn N8iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NqX/zsugDIFGqU1o5bPg+mfxcpflibTDWwvc6+6Rsf8=; b=SzFJaAZ66Q0/+BEoMmg0QEiVQlGMgCmwVeIFTtSyXtGeIdJLhP47eFhK4z7ttxt/dU XSEBgdOyxmTWzvkVW4ceZU4IVgsAKmOdgaIipRpvUfeV61shlTnPMk81xFaK6Y4YIZ7+ Pl2Ys3ENvZu9yvaLL5djEKE3lNiE3Y1yC37ZRh0/0w9PceaTEQS48wkGpxJWd2nuzGbR Cn3k55LZ7tMDPY45hlHalYvTUxaGD6hQxJmillMOykQTkbcFFE6zOmosT/w7DWTpdvTy VG2r8l+UbXqCG9H9xIulUY9F2r7tLh+d57l1G2lgKtKKYnrbcVUfsi6xv9gHfMjNXZy3 6Ipg== X-Gm-Message-State: APjAAAXMzdmte2r7yCLFUSjSdJjpP3+CwJWWQrBgpUJK1zeu3oJfUwht VutRhDFmRTrlD34Ywx4jArtfzqbH/vileEdKKTFyyw== X-Google-Smtp-Source: APXvYqyyDYYjNW4h7b6Yag9vpJCIRMLDKR2d8S/CnXzZgJktyNjXwofh2RTb311bPW1GJsEQlmfPNAEOOU6jKb2QhT8= X-Received: by 2002:a2e:781a:: with SMTP id t26mr4790826ljc.28.1565183501517; Wed, 07 Aug 2019 06:11:41 -0700 (PDT) MIME-Version: 1.0 References: <1564607463-28802-1-git-send-email-skomatineni@nvidia.com> <1564607463-28802-2-git-send-email-skomatineni@nvidia.com> In-Reply-To: From: Linus Walleij Date: Wed, 7 Aug 2019 15:11:29 +0200 Message-ID: Subject: Re: [PATCH v7 01/20] pinctrl: tegra: Add suspend and resume support To: Sowjanya Komatineni Cc: "thierry.reding@gmail.com" , Jon Hunter , Thomas Gleixner , Jason Cooper , Marc Zyngier , Stefan Agner , Mark Rutland , Peter De Schrijver , Prashant Gaikwad , Stephen Boyd , linux-clk , "open list:GPIO SUBSYSTEM" , jckuo@nvidia.com, Joseph Lo , talho@nvidia.com, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" , Mikko Perttunen , spatra@nvidia.com, Rob Herring , Dmitry Osipenko , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "Rafael J. Wysocki" , viresh kumar , Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 7, 2019 at 5:40 AM Sowjanya Komatineni wrote: > On 8/6/19 2:51 PM, Sowjanya Komatineni wrote: > > > > On 8/5/19 2:20 AM, Linus Walleij wrote: > >> On Wed, Jul 31, 2019 at 11:11 PM Sowjanya Komatineni > >> wrote: > >> > >>> This patch adds support for Tegra pinctrl driver suspend and resume. > >>> > >>> During suspend, context of all pinctrl registers are stored and > >>> on resume they are all restored to have all the pinmux and pad > >>> configuration for normal operation. > >>> > >>> Acked-by: Thierry Reding > >>> Reviewed-by: Dmitry Osipenko > >>> Signed-off-by: Sowjanya Komatineni > >> Patch applied to the pinctrl tree. > >> > >> This patch seems finished. > >> > >> Also if the rest don't get merged for v5.4 then at least this is so > >> your patch stack gets more shallow. > >> > >> I hope it's fine to merge this separately, else tell me and I'll > >> pull it out. > >> > >> Yours, > >> Linus Walleij > > > > Yes, this patch can be merged separately. But, there's latest feedback > > from Dmitry to add barrier after writes to make sure pinmux register > > writes happen. > > > > So will update this patch to add barrier in v8. So, need to wait for v8. > > > > Thanks > > > > Sowjanya > > > I see it merged. So will exclude suspend/resume patch and will add patch > for necessary write barrier fix in v8 version. Yeah just make an incremental patch, that's fine. If you want to overdo it you can add a Fixes: tag to the original patch, but I don't care much. Yours, Linus Walleij