From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71426C433EF for ; Thu, 21 Apr 2022 20:42:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1392521AbiDUUpl (ORCPT ); Thu, 21 Apr 2022 16:45:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1392470AbiDUUpg (ORCPT ); Thu, 21 Apr 2022 16:45:36 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 664954D617 for ; Thu, 21 Apr 2022 13:42:45 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id r189so10852662ybr.6 for ; Thu, 21 Apr 2022 13:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1b/BKquYiwOKFwAeMh2hNCCGUogn86K0gaqOcP9rSF4=; b=CjZtID8rzyqb2HE8iu3Rq+8rwTq3zUZDZgqyOdy6/kE4rjSrc0uw41BybDBNIPKrE4 QoSH6zhTTRGyc48UznXmQ5/fUSfoOFHFOCMF/g+kiQ2Yi8eCdFBwghbAoX+j0rcI9iSZ yGpfwif4BqCtStoMyZl7rrrVJeM5521z8zKK2jegBHRxZjPISs6U2q1gEt1bMfdrl852 K0TuFyQq3pvIetISRRYJnL784OXeYs+TiCK7LkGTvePGsONlVrAOfvmEs5zz+YKmWHlC JKAM48qWyov4loqHnLJ56xwM6UCfzk4oHGb4BzsDPPRE/bHcvmG7NvZGJADn9hmwOjK1 2esw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1b/BKquYiwOKFwAeMh2hNCCGUogn86K0gaqOcP9rSF4=; b=N8szEW+87I/CiAivj/MYY7CFfN79rhI3CRTw6XtfqR3tq7yDua9c5d1c9FOluqBoLB +Nl2xKVV73yxp9pO2YPYymrzeedFyvLQwcskjzCs7M0Ce7rH1CF339gzrgOm1+7E0Svw ZrmYLiyTOdh+PpCL5cX2Bgdxh61Ni/kxWxphpT3RVXbyuPx/yYDW2nB7MUfMURSDHt0U jLHdK7KoTQ0+UcK/GFuQ/94/kfFsUuAz7RmaXdMdfzHyLkQ+0QL/im3zpEF+/kECIUQD 6832cUspT5fZs70kOdSYY4NTbz7UETFEeRoNW4vDPuwQ4E24aibKhV5fFgt7ycrjd/uV yEtg== X-Gm-Message-State: AOAM532YN/I4lJv44IzXRb0LbGhxo9oz/vBbTqk1yX8yHoO2dBpVhHOE rpJJJhuA6FgdzXmZGPZGjC7nMCAvfjopwSxzezQvBQ== X-Google-Smtp-Source: ABdhPJzqdMV4NXfT0dm1w0jMpm6c09lLobEXVuimJSgXhcD/2XVRcL4YIEwQbKnb1VL+qltH9j3eNX8mRl8JGqKLIco= X-Received: by 2002:a25:a12a:0:b0:644:e94e:5844 with SMTP id z39-20020a25a12a000000b00644e94e5844mr1519306ybh.492.1650573764641; Thu, 21 Apr 2022 13:42:44 -0700 (PDT) MIME-Version: 1.0 References: <20220419071503.1596423-1-patrick.rudolph@9elements.com> <20220419071503.1596423-2-patrick.rudolph@9elements.com> In-Reply-To: <20220419071503.1596423-2-patrick.rudolph@9elements.com> From: Linus Walleij Date: Thu, 21 Apr 2022 22:42:33 +0200 Message-ID: Subject: Re: [PATCH 1/2] dt-binding: Add cypress,cy8c95x0 binding To: Patrick Rudolph Cc: Rob Herring , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Patrick, thanks for your patch! On Tue, Apr 19, 2022 at 9:17 AM Patrick Rudolph wrote: > Added device tree binding documentation for > Cypress CY8C95x0 I2C pin-controller. > > Signed-off-by: Patrick Rudolph > + '#gpio-cells': > + description: > + The first cell is the pin number and the second cell is used > + to specify optional parameters. > + const: 2 Maybe specify that the second cell uses the standard GPIO parameters in ? The driver is quite elaborate, you can probably list which parameters you support on this hardware even if the driver don't even implement them yet: it's just a binding after all. > + ngpios: > + minimum: 1 > + maximum: 60 Why? Isn't it obvious from the compatible how many pins the GPIO chip has? Then use that instead. Write under the compatible as description: for each chip how many gpios it has. > +patternProperties: > + '-pins$': > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: "/schemas/pinctrl/pincfg-node.yaml" This is impressive. It's quite advanced to use the pin config props for elaborate pin config control. Yours, LInus Walleij