linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpio: uniphier: include <linux/bits.h> instead of <linux/bitops.h>
@ 2018-10-16  4:11 Masahiro Yamada
  2018-10-16  8:03 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2018-10-16  4:11 UTC (permalink / raw)
  To: linux-gpio, Linus Walleij; +Cc: Masahiro Yamada, linux-arm-kernel, linux-kernel

The reason of including <linux/bitops.h> here is just for BIT() and
GENMASK macros.

Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
macros from <linux/bitops.h> to a new <linux/bits.h> file"),
<linux/bits.h> is enough for such compile-time macros.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpio/gpio-uniphier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c
index 7fdac90..74551cbd 100644
--- a/drivers/gpio/gpio-uniphier.c
+++ b/drivers/gpio/gpio-uniphier.c
@@ -12,7 +12,7 @@
  * GNU General Public License for more details.
  */
 
-#include <linux/bitops.h>
+#include <linux/bits.h>
 #include <linux/gpio/driver.h>
 #include <linux/irq.h>
 #include <linux/irqdomain.h>
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpio: uniphier: include <linux/bits.h> instead of <linux/bitops.h>
  2018-10-16  4:11 [PATCH] gpio: uniphier: include <linux/bits.h> instead of <linux/bitops.h> Masahiro Yamada
@ 2018-10-16  8:03 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-10-16  8:03 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: open list:GPIO SUBSYSTEM, Linux ARM, linux-kernel

On Tue, Oct 16, 2018 at 6:12 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK macros.
>
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-16  8:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16  4:11 [PATCH] gpio: uniphier: include <linux/bits.h> instead of <linux/bitops.h> Masahiro Yamada
2018-10-16  8:03 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).