From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755525AbdD1In5 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Apr 2017 04:43:57 -0400
Received: from mail-it0-f45.google.com ([209.85.214.45]:37687 "EHLO
        mail-it0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933489AbdD1Inb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Apr 2017 04:43:31 -0400
MIME-Version: 1.0
In-Reply-To: <1493367610-7330-1-git-send-email-agust@denx.de>
References: <1493367610-7330-1-git-send-email-agust@denx.de>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Fri, 28 Apr 2017 10:43:19 +0200
Message-ID: <CACRpkda0PDE1b0nud9OLmLX1VWJtEtXfe2s6ryze5_BawFUHaQ@mail.gmail.com>
Subject: Re:
To: Anatolij Gustschin <agust@denx.de>
Cc: Alexandre Courbot <gnurou@gmail.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 28, 2017 at 10:20 AM, Anatolij Gustschin <agust@denx.de> wrote:

> Subject: [PATCH v3] gpiolib: Add stubs for gpiod lookup table interface
>
> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
> for the !GPIOLIB case to prevent build errors. Also add prototypes.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> Changes in v3:
>  - add stubs for !GPIOLIB case. Drop prototypes, these are
>    already in gpio/machine.h

Yeah...

> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h

So why should the stubs be in <linux/gpio/consumer.h>
and not in <linux/gpio/machine.h>?

Yours,
Linus Walleij