From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A0AC433F5 for ; Tue, 15 Mar 2022 01:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344278AbiCOBYj (ORCPT ); Mon, 14 Mar 2022 21:24:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344258AbiCOBYh (ORCPT ); Mon, 14 Mar 2022 21:24:37 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CBE424587 for ; Mon, 14 Mar 2022 18:23:25 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id f38so34429165ybi.3 for ; Mon, 14 Mar 2022 18:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DUrggfzVKufzmWoIKvZEPz4GO4OdeAwImi0Sw1cUPLY=; b=Pp9U4iBz1c7RdL74LrziYiz0K9sqGHBLLfaiw7yuCobsSclKVyzEwCqiG22sJkP0ga swsO3N/Nup5cLeDeza3pXkR4oTq3FVm8FeVlfhRTxrlvcN2DltmKfxQ2lrv0pFdZyi/4 KwTLKqnuXPMXPHVuNysLSe0n6a6itKcOiQwMOuYJlQZZVRrYznnLIgsa8ZaJBtW5SRXc eOKD5h6tt1tikqIrk6zqwZTtljBgVxHfnYNYKeAWO/632CuHRAVakI18zekwRWndDpbT DYmmd3dRbCAmcGmvwebbUtivtqCj5CJvBkD0FGRR9BYQehHQPykOwLCJ/k/Vj6OlqawU 2pDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DUrggfzVKufzmWoIKvZEPz4GO4OdeAwImi0Sw1cUPLY=; b=ddX8Ycn+emqFI6aHR+Ap2mcduyil3wFA6/8YMDYeDy8UKsRG0qkutcMQOBENEoXooN BZPA76hLEO8vS7QPnKUL4rDRmqLFQWKgArs8wciMxQxMNDNyiOTXcBX97xH7UXbUPA5A AcvKDgpy2ws3YPeSM7yil0V/RmuGfy/QYmBSsKCHL8GwwcCx8885wbj76IWL4jpwOQPH vzUIPXN2pd3bzX9iY+tf9HdO96QaAsztDn9PYeKJS903lGunXD+dbyvO1DoV5+2OTN/5 BsjfcWyuOiIwRm/OVYWFnkatKTAlLVS3g7sF9z3rxQwYJmsFKGzogQs5lGNGbFi3N1DI sLgA== X-Gm-Message-State: AOAM532MBcH6y7nZ3VpJ/DBcU8U6ZKy6/RlJFLZuhrHCQQ139b2b9ZNk k7HFl2Z1gI8zi+UK8Nyhclnj6b7FGV41B44PvGe/xw== X-Google-Smtp-Source: ABdhPJxX9wsyLjHJ3JQDqbwra+5cFiaWtJHWVE2dwF0ABfopbXcx0SYg4eBTvzbtxvVMU36vKLIkAriWFyyD5rl/u1A= X-Received: by 2002:a5b:dc5:0:b0:624:f16d:7069 with SMTP id t5-20020a5b0dc5000000b00624f16d7069mr20041868ybr.295.1647307404617; Mon, 14 Mar 2022 18:23:24 -0700 (PDT) MIME-Version: 1.0 References: <20220307115116.25316-1-linmq006@gmail.com> In-Reply-To: <20220307115116.25316-1-linmq006@gmail.com> From: Linus Walleij Date: Tue, 15 Mar 2022 02:23:13 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: nomadik: Add missing of_node_put() in nmk_pinctrl_probe To: Miaoqian Lin Cc: Lee Jones , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 7, 2022 at 12:51 PM Miaoqian Lin wrote: > This node pointer is returned by of_parse_phandle() with refcount > incremented in this function. Calling of_node_put() to avoid > the refcount leak. > > Fixes: 32e67eee670e ("pinctrl: nomadik: Allow prcm_base to be extracted from Device Tree") > Signed-off-by: Miaoqian Lin Patch applied. Yours, Linus Walleij