From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756660AbcIGWFx (ORCPT ); Wed, 7 Sep 2016 18:05:53 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33040 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbcIGWFn (ORCPT ); Wed, 7 Sep 2016 18:05:43 -0400 MIME-Version: 1.0 In-Reply-To: <20160905225217.C34571A245A@localhost.localdomain> References: <20160905225217.C34571A245A@localhost.localdomain> From: Linus Walleij Date: Thu, 8 Sep 2016 00:05:42 +0200 Message-ID: Subject: Re: [PATCH] soc: fsl/qe: fix gpio save_regs functions To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Scott Wood , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org list" , "linux-gpio@vger.kernel.org" , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 6, 2016 at 12:52 AM, Christophe Leroy wrote: > of_mm_gpiochip_add_data() calls mm_gc->save_regs() before > setting the data. Therefore ->save_regs() cannot use > gpiochip_get_data() > > An Oops is encountered without this fix. > > fixes: 1e714e54b5ca5 ("powerpc: qe_lib-gpio: use gpiochip data pointer") > Signed-off-by: Christophe Leroy > Cc: Aha sorry for my regular screwups. :( Reviewed-by: Linus Walleij Yours, Linus Walleij