From: Linus Walleij <linus.walleij@linaro.org>
To: Phil Reid <preid@electromag.com.au>, Axel Lin <axel.lin@ingics.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Alexandre Courbot <gnurou@gmail.com>,
Gabor Juhos <juhosg@openwrt.org>,
Miguel Gaio <miguel.gaio@efixo.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: 74x164: Implement gpiochip.set_multiple()
Date: Tue, 22 Mar 2016 11:56:50 +0100 [thread overview]
Message-ID: <CACRpkda38uz2dDwyCPA4YucfMS3Jjjkz00oPOmmkK7rXZatRNg@mail.gmail.com> (raw)
In-Reply-To: <56E789C1.2070907@electromag.com.au>
On Tue, Mar 15, 2016 at 5:04 AM, Phil Reid <preid@electromag.com.au> wrote:
> pca953x does not update the cached data unless the write operation
> was successful. Which I folowed with the implement of set_multiple.
> However a number of other drivers update regardless.
> eg chip->buffer is updated even if the write_config fails.
>
> What is the preferred approach?
Obviously the other drivers are buggy and need to be fixed.
It can't be too many since the number of drivers with failable
write operations aren's so many. (And I guess they seldom fail
so it's not a big real world problem.) But it should be fixed.
Add Axel Lin to the thread, he's awesome at finding semantic
bugs.
Patches accepted :)
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-03-22 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 15:19 [PATCH] gpio: 74x164: Implement gpiochip.set_multiple() Geert Uytterhoeven
2016-03-15 4:04 ` Phil Reid
2016-03-22 10:56 ` Linus Walleij [this message]
2016-03-22 10:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda38uz2dDwyCPA4YucfMS3Jjjkz00oPOmmkK7rXZatRNg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=axel.lin@ingics.com \
--cc=geert+renesas@glider.be \
--cc=gnurou@gmail.com \
--cc=juhosg@openwrt.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.gaio@efixo.com \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).