From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbcEZJY0 (ORCPT ); Thu, 26 May 2016 05:24:26 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:33896 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbcEZJYZ (ORCPT ); Thu, 26 May 2016 05:24:25 -0400 MIME-Version: 1.0 In-Reply-To: <1464153722.20948.81.camel@aj.id.au> References: <1462515608-20566-1-git-send-email-andrew@aj.id.au> <1462515608-20566-2-git-send-email-andrew@aj.id.au> <1464153722.20948.81.camel@aj.id.au> Date: Thu, 26 May 2016 11:24:24 +0200 Message-ID: Subject: Re: [RFC PATCH] drivers/pinctrl: Add pinctrl-ast2400 From: Linus Walleij To: Andrew Jeffery Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Benjamin Herrenschmidt , Milton Miller II , Joel Stanley , Jeremy Kerr Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 7:22 AM, Andrew Jeffery wrote: > [Me] >> > +#define A4 2 >> > +SSSF_PIN_DECL(A4, GPIOA2, TIMER3, FUNC_DESC_SET(SCU80, 2)); >> > + >> > +FUNC_EXPR_DECL_SINGLE(SD1, FUNC_DESC_SET(SCU90, 0)); >> > + >> > +FUNC_EXPR_DECL_SINGLE(I2C10, FUNC_DESC_SET(SCU90, 23)); >> > + >> > +#define C4 16 >> > +MS_PIN_DECL(C4, GPIOC0, SD1, I2C10); >> > +#define B3 17 >> > +MS_PIN_DECL(B3, GPIOC1, SD1, I2C10); >> >> These things look very terse. But I guess there is no way to alleviate >> the terseness that you can think of? > > Less terse in what way? Something other than more descriptive/longer > the macro names? Well I was just thinking that it's hard to read and understand. But if it's complicated, it's complicated and that cannot be fixed by syntax. Algebra books are not and easy read either, hehe :) Yours, Linus Walleij