From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249AbbGUJ4w (ORCPT ); Tue, 21 Jul 2015 05:56:52 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:34005 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753892AbbGUJ4u convert rfc822-to-8bit (ORCPT ); Tue, 21 Jul 2015 05:56:50 -0400 MIME-Version: 1.0 In-Reply-To: <1437461993-14860-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <20150721132945.7ffc443b@canb.auug.org.au> <1437461993-14860-1-git-send-email-u.kleine-koenig@pengutronix.de> Date: Tue, 21 Jul 2015 11:56:49 +0200 Message-ID: Subject: Re: [PATCH] regulator: rk808: make better use of the gpiod API From: Linus Walleij To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Mark Brown , Liam Girdwood , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Chris Zhong , Sascha Hauer Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2015 at 8:59 AM, Uwe Kleine-König wrote: > The gpiod functions include variants for managed gpiod resources. Use it > to simplify the remove function. > > As the driver handles a device node without a specification of dvs gpios > just fine, additionally use the variant of gpiod_get exactly for this > use case. This makes error checking more strict. > > As a third benefit this patch makes the driver use the flags parameter > of gpiod_get* which will not be optional any more after 4.2 and so > prevents a build failure when the respective gpiod commit is merged. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > this is the more complete fix of the issue that Stephen found while creating > next-20150721 (see commit f51ec04cf8be9f7ef795f1f39ada17c19f725650). Reviewed-by: Linus Walleij Mark, please apply this. Yours, Linus Walleij