From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5457FC47094 for ; Thu, 10 Jun 2021 07:51:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34258613C8 for ; Thu, 10 Jun 2021 07:51:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230117AbhFJHxS (ORCPT ); Thu, 10 Jun 2021 03:53:18 -0400 Received: from mail-lf1-f48.google.com ([209.85.167.48]:33574 "EHLO mail-lf1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbhFJHxR (ORCPT ); Thu, 10 Jun 2021 03:53:17 -0400 Received: by mail-lf1-f48.google.com with SMTP id bp38so1771171lfb.0 for ; Thu, 10 Jun 2021 00:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BV0mX6VHU5X8dHAexL1PQHyIj2OEzudYmOcUzeY2MX4=; b=AdvT/igYobAKGf9/uDLDpNApWa3Pq6oV7rSkMR3xAYpt3CF1g7hBOIQXtIQnQnfLcg V9MCCOKKAbHgP6RiOfevPWvrGybrM0Uisq1KLDzOUrRYmAiMGJf4xjX8wG0zGPaKrC2H YtjNivLvnvqdYnnpF5TPK9UmUlmTSguPrDj30cheFYhIeKrdcGvDUn0VHt1DjPqlyISP wivifzrYIDWZN+HQJegNQQgvR6Yf9NxaB2YBqkfqwbHZjfXWNuu+wZQ120m3N83COajN pMoqB3XHUVSNPnWkV8KMdiR6S4l1UuE99hUPw9UX7pd7CLJj6lSgNilo0vQ6pn76sXTS eiGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BV0mX6VHU5X8dHAexL1PQHyIj2OEzudYmOcUzeY2MX4=; b=jePQK9mdk2hjh0bREGhpP+M+GVR89i8K8KT5SzXac5qWTKwJw8ICmwUWIW+XVJnhIh 6ol8UpoKF7H5FeRjxlgeQMKqoJFARBHkDSyx+kS2j0JGLP14LAmF4o+cHXULhp+ny5++ Gju5nfS8aQdSxQUNol+/UrslI26EfibR2xVOoei5ay0eoBx00WcAKztlly1Em04ybHgS bKyuQZP38Z6vNzasZ0JH+WQypW3VNcUe6dHenvFdKwnv54ysYKMj1rpa0WQ5GjqoEQjR G4t8wqgSywxupHvuofEoRH1cZrfblPaGFXZV2kgUXSPYThse8gb/Gavpa7FCDCVtmF3s 762w== X-Gm-Message-State: AOAM533I1qiW5gnObkCMFHcH4vCkTFa0zhmt+FacLV18zT/SksV6bnr0 ZDwgLuz4g3X6iuhE8oYqsg/vOh4nFfrVWzOkH657iA== X-Google-Smtp-Source: ABdhPJwXgej17X2Hq45GoFUg6Fkxs282tt7kcgRz+7nJDajhBBMWhiNOQrCm3BSAzecuEcF6CuKi3ff9MxykHNNR6SE= X-Received: by 2002:a05:6512:20c9:: with SMTP id u9mr1074510lfr.291.1623311420585; Thu, 10 Jun 2021 00:50:20 -0700 (PDT) MIME-Version: 1.0 References: <20210608102547.4880-1-steven_lee@aspeedtech.com> <20210610022416.GA27188@aspeedtech.com> In-Reply-To: <20210610022416.GA27188@aspeedtech.com> From: Linus Walleij Date: Thu, 10 Jun 2021 09:50:09 +0200 Message-ID: Subject: Re: [PATCH v5 00/10] ASPEED sgpio driver enhancement. To: Steven Lee Cc: Bartosz Golaszewski , Rob Herring , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Hongwei Zhang , Ryan Chen , Billy Tsai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 4:24 AM Steven Lee wrote: > Per the comment in the following mail > https://lkml.org/lkml/2021/6/9/317 > > I was wondering if I should prepare v6 for the currnet solution or > I should drop this patch series then prepare another patch for the > new solution(piar GPIO input/output) which breaks userspace but is > better than the current solution. I would say just go ahead with the new solution. AFAIK Aspeed has pretty tight control over what kind of userspace run on these systems. BTW please influence Aspeed to use the GPIO character device and ligpiod https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/ if you are doing any kind of userspace GPIO control (which I suspect that you do). Yours, Linus Walleij