From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752859AbdF2WQQ (ORCPT ); Thu, 29 Jun 2017 18:16:16 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:38312 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbdF2WQO (ORCPT ); Thu, 29 Jun 2017 18:16:14 -0400 MIME-Version: 1.0 In-Reply-To: <1498748238.27840.5.camel@baylibre.com> References: <1497543642.3086.35.camel@baylibre.com> <1497954416.7387.1.camel@baylibre.com> <1497979438.7387.10.camel@baylibre.com> <1498141515.7387.16.camel@baylibre.com> <0e12f9bd-4e0b-c602-5627-5dbda5371dee@ti.com> <1498587929.25567.12.camel@baylibre.com> <1498748238.27840.5.camel@baylibre.com> From: Linus Walleij Date: Fri, 30 Jun 2017 00:16:12 +0200 Message-ID: Subject: Re: [RFC] gpio: about the need to manage irq mapping dynamically. To: Jerome Brunet Cc: Grygorii Strashko , "linux-gpio@vger.kernel.org" , Marc Zyngier , "open list:ARM/Amlogic Meson..." , Kevin Hilman , Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2017 at 4:57 PM, Jerome Brunet wrote: > On Thu, 2017-06-29 at 16:14 +0200, Linus Walleij wrote: >> So I changed my mind, it is fine for this type of driver to call >> irq_create_mapping() in gpio_to_irq(). Preferably with some comment >> around the call. > > What about disposing of the mapping ? there still is no counter part function to > gpio_to_irq. It seems weird to leave them lying around, don't you think ? Yeah that sucks. We need a way to fix that. Is gpio_irq_prepare/unprepare the right approach? Yours, Linus Walleij