linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: michal.simek@xilinx.com, michal.simek@amd.com, git@amd.com,
	shubhrajyoti.datta@xilinx.com, srinivas.neeli@xilinx.com,
	brgl@bgdev.pl, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, srinivas.goud@amd.com,
	manion05gk@gmail.com
Subject: Re: [PATCH V2] gpio: zynq: fix zynqmp_gpio not an immutable chip warning
Date: Fri, 9 Jun 2023 09:49:08 +0200	[thread overview]
Message-ID: <CACRpkda7TrNckpS5rLadv=eYRCDDN1qTBUp=jr+KfgoaQy8z7g@mail.gmail.com> (raw)
In-Reply-To: <1686249772-26231-1-git-send-email-manikanta.guntupalli@amd.com>

On Thu, Jun 8, 2023 at 8:43 PM Manikanta Guntupalli
<manikanta.guntupalli@amd.com> wrote:

> Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE,
> call gpiochip_disable_irq() in the .irq_mask() callback and
> gpiochip_enable_irq() in the .irq_unmask() callback to fix
> "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning.
>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>

This v2 looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

  reply	other threads:[~2023-06-09  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 18:42 [PATCH V2] gpio: zynq: fix zynqmp_gpio not an immutable chip warning Manikanta Guntupalli
2023-06-09  7:49 ` Linus Walleij [this message]
2023-06-13  9:49 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkda7TrNckpS5rLadv=eYRCDDN1qTBUp=jr+KfgoaQy8z7g@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=git@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manikanta.guntupalli@amd.com \
    --cc=manion05gk@gmail.com \
    --cc=michal.simek@amd.com \
    --cc=michal.simek@xilinx.com \
    --cc=shubhrajyoti.datta@xilinx.com \
    --cc=srinivas.goud@amd.com \
    --cc=srinivas.neeli@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).