From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FAC6C4332F for ; Mon, 28 Feb 2022 23:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbiB1XoL (ORCPT ); Mon, 28 Feb 2022 18:44:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbiB1XoJ (ORCPT ); Mon, 28 Feb 2022 18:44:09 -0500 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C6CC3FBE1 for ; Mon, 28 Feb 2022 15:43:28 -0800 (PST) Received: by mail-yb1-xb30.google.com with SMTP id g6so23801497ybe.12 for ; Mon, 28 Feb 2022 15:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qv0zsMcKFZS0uEN+5UZdpCCNfqy5Tylio2s1vY2ryso=; b=ap5urwZneNBvZkhWi+/alykrLvq+JYqyG5CVt8WwKGtLHNLfvdGlkCi9jb2IB8Dbev MBDfUFmIVhBVZZbas/oLB3vPRnZPejc3kafHFSDs/G7H4Yj4XWQedGscnKmawKj9QX55 /X7Jk+kO+yQYrIH8mst8QcYrJcns7dbxoluyOJQm/6lXSz5ROZU4Dwir6Q9PMF09VRsF v1D9R1V2FGi1y5W50xxGS/sHAgitGOSEZSB9bfZXn373UY+vy0mS5V4ixrPsaMulrpKB bOTyoKOAoaw/HBLLkgDMiWzc9WtHQfgGlK8LMXxnRpkt3c0D9CcIoifuZS1dZHhWFt52 jv7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qv0zsMcKFZS0uEN+5UZdpCCNfqy5Tylio2s1vY2ryso=; b=Jwkw400AmK+eEd0a6SI2Nn+wyh6mrf60/6D7eYJUsDorndeJnFLde2T2cQ87ChDJxP 8sWd+r0Y5mlSVv2HcyQscF9BmaXbaYOuQQkZB4muevIG5IhUHUXU9UhZJxUPuw+3pQS5 x4spkWO9b96PgMhSv3dzpEKq7fHF8pCYtzPiM7g0b0KQxAXzhOZW2xKRcJWjtsS6FRpR ABljGLfCRr+MuJGE8Yl5NUwJZ17A7QgavfSWH/gI3Dbv9l6N929BvaDbNkvutVrTPlEQ QmtKPpq9xOzZnoNJwCBvzyraXvC5gN0TjtrPp8YzMuszAezPdY2XgN22ncQKjtqqwByg co3Q== X-Gm-Message-State: AOAM5303+zPcsTKSjKjFMvM1UzX3FJgQVki/2IaqTr8FivzRv4lso4nt 0Y8FNC4WVOxuCvls8yih8mUYczINBciwp8klkkKq3g== X-Google-Smtp-Source: ABdhPJy1LX+l2Mo/igXclj6eX4Kw6KzE1vcvAQRdRbdEaIC9clnEKE1E4s62KfDnNCE8OdnKYLa2bNj2oAdbjzW0rhA= X-Received: by 2002:a25:9108:0:b0:61e:329:700 with SMTP id v8-20020a259108000000b0061e03290700mr21280699ybl.369.1646091807701; Mon, 28 Feb 2022 15:43:27 -0800 (PST) MIME-Version: 1.0 References: <20220215163926.894-1-paweldembicki@gmail.com> In-Reply-To: <20220215163926.894-1-paweldembicki@gmail.com> From: Linus Walleij Date: Tue, 1 Mar 2022 00:43:16 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board To: Pawel Dembicki Cc: Rob Herring , Arnd Bergmann , Olof Johansson , soc@kernel.org, Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Shawn Guo , Sam Ravnborg , Corentin Labbe , Oleksij Rempel , Hao Fang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 15, 2022 at 5:40 PM Pawel Dembicki wrote: > +&i2c0 { > + status = "okay"; > + > + rtc@30 { > + compatible = "s35390a"; > + reg = <0x30>; > + }; > + > + lm63@4c { > + compatible = "national,lm63"; > + reg = <0x4c>; > + }; Think about adding chassis thermal zone for this sensor, I suppose you don't have any active control of cooling (fan)? This often sits on GPIO... In that case just add a critical temperature so it can't burn down the house. See: arch/arm/boot/dts/gemini-dlink-dns-313.dts node thermal-zones {} for an example of how to do this quick and easy. You need CONFIG_THERMAL and CONFIG_THERMAL_HWMON for this to work. Yours, Linus Walleij