From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbbHRMAa (ORCPT ); Tue, 18 Aug 2015 08:00:30 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:32884 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbbHRMA3 (ORCPT ); Tue, 18 Aug 2015 08:00:29 -0400 MIME-Version: 1.0 In-Reply-To: <20150818165719.5ac6f687@canb.auug.org.au> References: <20150818165719.5ac6f687@canb.auug.org.au> Date: Tue, 18 Aug 2015 14:00:28 +0200 Message-ID: Subject: Re: linux-next: build failure after merge of the gpio tree From: Linus Walleij To: Stephen Rothwell , Mauro Carvalho Chehab Cc: "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Philipp Zabel , Hans Verkuil , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2015 at 8:57 AM, Stephen Rothwell wrote: > Hi Linus, > > After merging the gpio tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/media/i2c/tc358743.c: In function 'tc358743_probe_of': > drivers/media/i2c/tc358743.c:1786:22: error: too few arguments to function 'devm_gpiod_get' > state->reset_gpio = devm_gpiod_get(dev, "reset"); > ^ > In file included from drivers/media/i2c/tc358743.c:34:0: > include/linux/gpio/consumer.h:73:32: note: declared here > struct gpio_desc *__must_check devm_gpiod_get(struct device *dev, > ^ Argh. > I have added the following fix patch for today: > > From: Stephen Rothwell > Date: Tue, 18 Aug 2015 16:53:21 +1000 > Subject: [PATCH] [media] tc358743: fix for devm_gpiod_get API change > > Signed-off-by: Stephen Rothwell > --- > drivers/media/i2c/tc358743.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c > index fe42c9a1cb78..8f7641164d9d 100644 > --- a/drivers/media/i2c/tc358743.c > +++ b/drivers/media/i2c/tc358743.c > @@ -1783,7 +1783,7 @@ static int tc358743_probe_of(struct tc358743_state *state) > state->pdata.ths_trailcnt = 0x2; > state->pdata.hstxvregcnt = 0; > > - state->reset_gpio = devm_gpiod_get(dev, "reset"); > + state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS); > if (IS_ERR(state->reset_gpio)) { > dev_err(dev, "failed to get reset gpio\n"); > ret = PTR_ERR(state->reset_gpio); This is likely the correct solution. Mauro, can you apply Stephen's patch to your media tree? Yours, Linus Walleij