From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752917AbaF0Hof (ORCPT ); Fri, 27 Jun 2014 03:44:35 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:48989 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbaF0Hod (ORCPT ); Fri, 27 Jun 2014 03:44:33 -0400 MIME-Version: 1.0 In-Reply-To: <1403703451-12233-2-git-send-email-t.figa@samsung.com> References: <1403703451-12233-1-git-send-email-t.figa@samsung.com> <1403703451-12233-2-git-send-email-t.figa@samsung.com> Date: Fri, 27 Jun 2014 09:44:28 +0200 Message-ID: Subject: Re: [PATCH v2 1/6] ARM: mm: cache-l2x0: Add base address argument to write_sec callback From: Linus Walleij To: Tomasz Figa Cc: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Linux-OMAP , Kukjin Kim , Laura Abbott , Russell King - ARM Linux , Santosh Shilimkar , Tony Lindgren , Tomasz Figa , Daniel Drake , Marek Szyprowski Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 25, 2014 at 3:37 PM, Tomasz Figa wrote: > For certain platforms (e.g. Exynos) it is necessary to read back some > values from registers before they can be written (i.e. SMC calls that > set multiple registers per call), so base address of L2C controller is > needed for .write_sec operation. This patch adds base argument to > .write_sec callback so that its implementation can also access registers > directly. > > Signed-off-by: Tomasz Figa > arch/arm/mach-ux500/cache-l2x0.c | 3 ++- In our case just changing the signature of the function I see so: Acked-by: Linus Walleij Yours, Linus Walleij