linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Haojian Zhuang <haojian.zhuang@marvell.com>
Cc: swarren@nvidia.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, eric.y.miao@gmail.com,
	linux@arm.linux.org.uk, arnd@arndb.de
Subject: Re: [PATCH v4 1/3] pinctrl: enable pinmux for mmp series
Date: Tue, 10 Jan 2012 10:13:12 +0100	[thread overview]
Message-ID: <CACRpkdaA49pxgseaZNZggQx0GGc3P14tmFzTnxT3fTc2XAJcTA@mail.gmail.com> (raw)
In-Reply-To: <1325643995-20745-2-git-send-email-haojian.zhuang@marvell.com>

On Wed, Jan 4, 2012 at 3:26 AM, Haojian Zhuang
<haojian.zhuang@marvell.com> wrote:

> Support PXA168/PXA910/MMP2 pinmux. Now only support function switch.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>

I've applied this to my devel branch. It's pretty huge but since it's
split over three files I guess I can live with it. I can also see that
you have really made an effort to cover the PXA variants and
these drivers give a real good abstraction and understanding of
this muxing hardware so WELL DONE!

I fixed a number of whitespace issues, so please base your further
work upon my tree (once it emerges after the merge window).

I also removed the .maxpin on all pinctrl_desc:s, since that is
gone now, we get the max pin from the pin list instead, so it's
self-describing.

When I see things like this:

	PINCTRL_PIN(GPIO0, "GPIO0"),
	PINCTRL_PIN(GPIO1, "GPIO1"),
	PINCTRL_PIN(GPIO2, "GPIO2"),
	PINCTRL_PIN(GPIO3, "GPIO3"),
	PINCTRL_PIN(GPIO4, "GPIO4"),
	PINCTRL_PIN(GPIO5, "GPIO5"),

I wish I could have loops in the preprocessor and just
PINCTRL_PIN_RANGE("GPIO", start, end)
but sadly I can't. So as mentioned earlier we might go for
some static inline helper that can generate that array before you
assign it to your pin controller.

Maybe the device tree is the answer to everything (as usual). Given the
time it seems to take to find consensus around DT stuff we might just
have to wait and see.

Yours,
Linus Walleij

  reply	other threads:[~2012-01-10  9:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04  2:26 [PATCH v4 0/3] implement pinmux for arch-mmp Haojian Zhuang
2012-01-04  2:26 ` [PATCH v4 1/3] pinctrl: enable pinmux for mmp series Haojian Zhuang
2012-01-10  9:13   ` Linus Walleij [this message]
2012-01-04  2:26 ` [PATCH v4 2/3] ARM: mmp: enable pinmux in mmp platform Haojian Zhuang
2012-01-10  8:52   ` Linus Walleij
2012-01-10  9:05     ` Haojian Zhuang
2012-01-10 10:46       ` Linus Walleij
2012-01-04  2:26 ` [PATCH v4 3/3] gpio: pxa: request pinmux function for gpio Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdaA49pxgseaZNZggQx0GGc3P14tmFzTnxT3fTc2XAJcTA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).