From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757940Ab2IJNFT (ORCPT ); Mon, 10 Sep 2012 09:05:19 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:56634 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757760Ab2IJNFP (ORCPT ); Mon, 10 Sep 2012 09:05:15 -0400 MIME-Version: 1.0 In-Reply-To: <1347016499-29354-17-git-send-email-lee.jones@linaro.org> References: <1347016499-29354-1-git-send-email-lee.jones@linaro.org> <1347016499-29354-17-git-send-email-lee.jones@linaro.org> Date: Mon, 10 Sep 2012 06:05:13 -0700 Message-ID: Subject: Re: [PATCH 16/19] mfd: Provide the tc3589x with its own IRQ domain From: Linus Walleij To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, Samuel Ortiz Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones wrote: > In preparation for Device Tree enablement all IRQ controllers > should control their own IRQ domain. This patch provides just > that. > > CC: Samuel Ortiz > Signed-off-by: Lee Jones It's always nice to have irqdomains added, excellent patch! > + if (base) { > + tc3589x->domain = irq_domain_add_legacy( > + NULL, TC3589x_NR_INTERNAL_IRQS, base, > + 0, &tc3589x_irq_ops, tc3589x); > } > + else { > + tc3589x->domain = irq_domain_add_linear( > + NULL, TC3589x_NR_INTERNAL_IRQS, > + &tc3589x_irq_ops, tc3589x); > + } This is especially elegant, well done. Not my subsystem, but FWIW: Acked-by: Linus Walleij Yours, Linus Walleij