From: Linus Walleij <linus.walleij@linaro.org>
To: Wen Nuan <leo.wen@rock-chips.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg KH <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
jacob2.chen@rock-chips.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org, Eddie Cai <eddie.cai@rock-chips.com>
Subject: Re: [PATCH V2 2/2] dt-bindings: Document the Rockchip RK1608 bindings
Date: Mon, 26 Feb 2018 11:17:41 +0100 [thread overview]
Message-ID: <CACRpkdaD+kFcOKP+V642r86hqwOO7h1UyA4wWBqGWdm3mjuhLA@mail.gmail.com> (raw)
In-Reply-To: <1519633504-64357-1-git-send-email-leo.wen@rock-chips.com>
On Mon, Feb 26, 2018 at 9:25 AM, Wen Nuan <leo.wen@rock-chips.com> wrote:
> From: Leo Wen <leo.wen@rock-chips.com>
>
> Add DT bindings documentation for Rockchip RK1608.
>
> Changes V2:
> - Delete spi-min-frequency property.
> - Add the external sensor's control pin and clock properties.
> - Delete the '&pinctrl' node.
>
> Signed-off-by: Leo Wen <leo.wen@rock-chips.com>
(...)
> +- reset-gpio : GPIO connected to reset pin;
> +- irq-gpio : GPIO connected to irq pin;
> +- sleepst-gpio : GPIO connected to sleepst pin;
> +- wakeup-gpio : GPIO connected to wakeup pin;
> +- powerdown-gpio : GPIO connected to powerdown pin;
All these should be named something like:
reset-gpios = <>;
irq-gpios = <>;
etc
See
Documentation/devicetree/bindings/gpio/gpio.txt
So all in pluralis even if it is just one line, that is the standard.
> +- rockchip,powerdown0 : GPIO connected to the sensor0's powerdown pin;
> +- rockchip,reset0 : GPIO connected to the sensor0's reset pin;
> +- rockchip,powerdown1 : GPIO connected to the sensor1's powerdown pin;
> +- rockchip,reset1 : GPIO connected to the sensor1's reset pin;
Also get rid of the custom names here, either no lines should
have a "rockchip", prefix or all of them. Use the name of the
pin on the component, I suspect just
powerdown0-gpios
reset0-gpios
etc
By using the standard "*-gpios" suffix the kernel consumer API
will be much happier as well when you use gpiod_get() & friends.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-02-26 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:25 [PATCH V2 2/2] dt-bindings: Document the Rockchip RK1608 bindings Wen Nuan
2018-02-26 10:17 ` Linus Walleij [this message]
2018-03-07 9:53 ` Sakari Ailus
2018-03-08 0:46 ` leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaD+kFcOKP+V642r86hqwOO7h1UyA4wWBqGWdm3mjuhLA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=davem@davemloft.net \
--cc=eddie.cai@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacob2.chen@rock-chips.com \
--cc=leo.wen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).