From: Linus Walleij <linus.walleij@linaro.org>
To: Leonard Crestez <cdleonard@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Daniel Drake <drake@endlessm.com>,
Nitesh Kumar Agrawal <Nitesh-kumar.Agrawal@amd.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: Interrupt storm from pinctrl-amd on Acer AN515-42
Date: Fri, 28 Dec 2018 13:48:29 +0100 [thread overview]
Message-ID: <CACRpkdaDT9xZe6r3pJvYqubrvHh4+PkV8D38yYMEbv8fhdHMKQ@mail.gmail.com> (raw)
In-Reply-To: <4085fc648ff5086bd6e6237d74d2a11e945a617b.camel@gmail.com>
On Fri, Dec 28, 2018 at 12:02 AM Leonard Crestez <cdleonard@gmail.com> wrote:
> Digging a little deeper it seems the touchpad interrupt is active on
> boot and since it's configured as "level" and no touchpad driver is
> available yet there does not seem to be any way to clear it.
I think these are called "spurious interrupts".
> I don't know how this should be handled, booting with an active enabled but
> unclearable interrupt seems like a platform bug to me. There is even an
> option to set touchpad to "basic" which does some sort of ps2 emulation
> but the IRQ issue still happens!
>
> One workaround is to explicitly disable the interrupt from the handler
> if no mapping is found; this will keep it disabled until
> amd_gpio_irq_set_type is called later.
I don't know how x86 and ACPI systems usually deal with this stuff
so I'm kind of lost. On the embedded systems that I develop on,
I would just disable all interrupts on probe() (usually writing 0x0 in
some interrupt enable register) and then they will get enabled
once consumers need them.
But I have come to understand that maybe ACPI systems are
not so happy about drivers doing things like that?
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-12-28 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 23:02 Interrupt storm from pinctrl-amd on Acer AN515-42 Leonard Crestez
2018-12-28 12:48 ` Linus Walleij [this message]
2019-01-08 15:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaDT9xZe6r3pJvYqubrvHh4+PkV8D38yYMEbv8fhdHMKQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Nitesh-kumar.Agrawal@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cdleonard@gmail.com \
--cc=djkurtz@chromium.org \
--cc=drake@endlessm.com \
--cc=hdegoede@redhat.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).