* [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression
@ 2016-11-05 14:35 Heinrich Schuchardt
2016-11-07 9:05 ` Patrice Chotard
2016-11-08 10:27 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2016-11-05 14:35 UTC (permalink / raw)
To: Patrice Chotard, Linus Walleij
Cc: linux-arm-kernel, kernel, linux-gpio, linux-kernel, Heinrich Schuchardt
for_each_property_of_node(pins, pp) checks that pp is not NULL.
So there is no need to check it inside the loop.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/pinctrl/pinctrl-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 8308f15..676efcc 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1181,7 +1181,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
if (!strcmp(pp->name, "name"))
continue;
- if (pp && (pp->length/sizeof(__be32)) >= OF_GPIO_ARGS_MIN) {
+ if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) {
npins++;
} else {
pr_warn("Invalid st,pins in %s node\n", np->name);
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression
2016-11-05 14:35 [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression Heinrich Schuchardt
@ 2016-11-07 9:05 ` Patrice Chotard
2016-11-08 10:27 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Patrice Chotard @ 2016-11-07 9:05 UTC (permalink / raw)
To: Heinrich Schuchardt, Linus Walleij
Cc: linux-arm-kernel, kernel, linux-gpio, linux-kernel
On 11/05/2016 03:35 PM, Heinrich Schuchardt wrote:
> for_each_property_of_node(pins, pp) checks that pp is not NULL.
> So there is no need to check it inside the loop.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/pinctrl/pinctrl-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 8308f15..676efcc 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1181,7 +1181,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> if (!strcmp(pp->name, "name"))
> continue;
>
> - if (pp && (pp->length/sizeof(__be32)) >= OF_GPIO_ARGS_MIN) {
> + if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) {
> npins++;
> } else {
> pr_warn("Invalid st,pins in %s node\n", np->name);
>
Hi Heinrich
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression
2016-11-05 14:35 [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression Heinrich Schuchardt
2016-11-07 9:05 ` Patrice Chotard
@ 2016-11-08 10:27 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-11-08 10:27 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Patrice Chotard, linux-arm-kernel,
open list:ARM/STI ARCHITECTURE, linux-gpio, linux-kernel
On Sat, Nov 5, 2016 at 3:35 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> for_each_property_of_node(pins, pp) checks that pp is not NULL.
> So there is no need to check it inside the loop.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Patch applied with Patrice's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-08 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-05 14:35 [PATCH 1/1] pinctrl: st: st_pctl_dt_parse_groups simplify expression Heinrich Schuchardt
2016-11-07 9:05 ` Patrice Chotard
2016-11-08 10:27 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).