From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751135AbdE2Mbg (ORCPT ); Mon, 29 May 2017 08:31:36 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:33647 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbdE2Mbe (ORCPT ); Mon, 29 May 2017 08:31:34 -0400 MIME-Version: 1.0 In-Reply-To: <272048835491193427a32c442627be985eeba649.1495814557.git.jan.kiszka@siemens.com> References: <272048835491193427a32c442627be985eeba649.1495814557.git.jan.kiszka@siemens.com> From: Linus Walleij Date: Mon, 29 May 2017 14:31:32 +0200 Message-ID: Subject: Re: [PATCH v3 03/10] gpio-exar/8250-exar: Fix passing in of parent PCI device To: Jan Kiszka Cc: Greg Kroah-Hartman , Alexandre Courbot , Linux Kernel Mailing List , "linux-serial@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Sudip Mukherjee , Andy Shevchenko , Sascha Weisenberger Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 6:02 PM, Jan Kiszka wrote: > This fixes reloading of the GPIO driver for the same platform device > instance as created by the exar UART driver: First of all, the driver > sets drvdata to its own value during probing and does not restore the > original value on exit. But this won't help anyway as the core clears > drvdata after the driver left. > > Set the platform device parent instead. > > Signed-off-by: Jan Kiszka Acked-by: Linus Walleij Yours, Linus Walleij