From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751180AbcIGWNj (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 18:13:39 -0400
Received: from mail-oi0-f44.google.com ([209.85.218.44]:35391 "EHLO
        mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750754AbcIGWN3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 18:13:29 -0400
MIME-Version: 1.0
In-Reply-To: <1473170343-16853-1-git-send-email-marc.zyngier@arm.com>
References: <1473170343-16853-1-git-send-email-marc.zyngier@arm.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 8 Sep 2016 00:13:27 +0200
Message-ID: <CACRpkdaLf5H6qhF0kS5W-p3YmKh5DxZxyinoV5u9HBKts9CQLg@mail.gmail.com>
Subject: Re: [RFC PATCH] gpio/gpiolib: Forbid irqchip default trigger if
 probed over DT
To: Marc Zyngier <marc.zyngier@arm.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 6, 2016 at 3:59 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:

> Using a default trigger is a bad idea if using DT to configure
> interrupts, as the device's interrupt specifier will always contain
> the trigger configuration.
>
> Let's warn about that particular situation, and revert to not
> having a default. Hopefully, the couple of drivers still using
> this feature will quickly be fixed.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Patch applied. This is a good way to get rid of this madness.

> +       /*
> +        * Specifying a default trigger is a terrible idea if DT is
> +        * used to configure the interrupts, as you may end-up with
> +        * conflicting triggers. Tell the user, and reset to NONE.
> +        */
> +       if (WARN_ON(of_node && type != IRQ_TYPE_NONE,
> +                   "%s: Ignoring %d default trigger\n", of_node->full_name))
> +               type = IRQ_TYPE_NONE;

I *strongly* suspect this is bad also when using ACPI.

Would the GPIO ACPI people devise a patch on top of this
to emit the same warning for the ACPI usecase?

Yours,
Linus Walleij