From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13CF5C433EF for ; Thu, 5 May 2022 14:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379913AbiEEOhD (ORCPT ); Thu, 5 May 2022 10:37:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380685AbiEEOg7 (ORCPT ); Thu, 5 May 2022 10:36:59 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEB745AA6F for ; Thu, 5 May 2022 07:33:18 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id s30so7937473ybi.8 for ; Thu, 05 May 2022 07:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mjPMNwsrp6J5GYko2SAtRJngBnVXhB8jFuWLYKEwiPY=; b=fewd6t0m8AlbJsOL8rMMtmdSbrblLC+tou4WQa5Ukx0fDLML8yOTTiI03IEYZHxp2c 5W5CFU2Qo00NadwNz4fu2sdMo4N/fhzCDiGLHlJnCCs1Ua3dcldY61sEg61hMdSawUir 7eSZQI2CebwLUn4u4p9Bz1nt0xWXEswSQ1mxvA/ee4Uu5XXGOucd4+6oSzUonl+Kg0LI 8uOzDzX7qYjSqNbAmA90tOmmW4qdH/x0e5n5IbhGhckydFuX0s17/FQo0madWUU2q0+q rIcDxGLzvzfaBFeSvXHNgwp/tqsLvfCOnU4JqRfERHcRhzltPIYSlpBkJGsKowlUJZN7 2CtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mjPMNwsrp6J5GYko2SAtRJngBnVXhB8jFuWLYKEwiPY=; b=punCZUt7k+2tCMr1jxdbjwLN+WvxsrDrTmcP7dlKrHUljgSU0WBMc4ECqwOgLDn3ix GIimsXAKhZu6J1PiDMtMVraGcaMrcHZOxYve/aLGbbnxTdl92wsC6zpzPJQZFpK9MRl5 TjtyU5AyLU6kCLOxlsGfiEpza47LHXKuFeIL0K0cEZogwiv2yGcL4f/OJ0X16sEhU4Yo THPWzH0BWGf237iBBpbKQtLCUYwCj09NNYqE3Vf4jn0lYZX4uC20jHdTC9dubvU094Ss bPVGEhmv/SIGmVqmnffONcGgv58Adla6awk76TQ+YKKyVqzTWpkZXxM0TIA0ZiYT/tSg FtVQ== X-Gm-Message-State: AOAM530WKvW9DF5kfiEy1EEKb9kE1qpi1ryW7/D6acYV/fMufSSwk+Fs wxgocJEN0Dfl+elUupyEkMSAAN4qk33udqEAHx5nUQ== X-Google-Smtp-Source: ABdhPJwo8Hf6LSoTaiB2cHkTaFM0+gz3ZfG++D4wXVwew3EevAVlxRmwDqgoKNolEWO5oTKK+x6Cg+35P6TVPloh+u0= X-Received: by 2002:a25:bcc7:0:b0:648:d728:d39 with SMTP id l7-20020a25bcc7000000b00648d7280d39mr22199185ybm.514.1651761198027; Thu, 05 May 2022 07:33:18 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-19-arnd@kernel.org> In-Reply-To: From: Linus Walleij Date: Thu, 5 May 2022 16:33:06 +0200 Message-ID: Subject: Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio To: Arnd Bergmann Cc: Robert Jarzmik , Linux ARM , Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , IDE-ML , linux-clk , Linux PM list , "open list:HID CORE LAYER" , patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc , linux-mtd , linux-rtc@vger.kernel.org, USB list , Linux Fbdev development list , dri-devel , ALSA Development Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > On Wed, May 4, 2022 at 11:59 PM Linus Walleij wrote: > > Thus drop one ! in front of the expression, just !SND_SOC_DAPM_EVENT_ON(event) > > Ok, done. But I still leave the extra 'invert=1' in hs_jack_pin[], right? > > /* Headphones jack detection DAPM pin */ > static struct snd_soc_jack_pin hs_jack_pin[] = { > { > .pin = "Headphone Jack", > .mask = SND_JACK_HEADPHONE, > }, > { > .pin = "Speaker", > /* disable speaker when hp jack is inserted */ > .mask = SND_JACK_HEADPHONE, > .invert = 1, > }, Hm some ASoC thingie. No idea what that is, but I suppose another place where a subsystem for legacy reasons try to do the gpiolib inversion on it's own accord. That one isn't flagged as active low in the descriptor so it's fine I guess. Possible this should be fixed in ASoC to rely on gpiolib but we can't fix the entire world. Yours, Linus Walleij