From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751566Ab2KFKPZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Nov 2012 05:15:25 -0500
Received: from mail-ee0-f46.google.com ([74.125.83.46]:52338 "EHLO
	mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750755Ab2KFKPW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Nov 2012 05:15:22 -0500
MIME-Version: 1.0
In-Reply-To: <20121106093904.GM24532@intel.com>
References: <1351928793-14375-1-git-send-email-mika.westerberg@linux.intel.com>
	<4684026.MA6h34pt1X@vostro.rjw.lan>
	<CACRpkdbRWPYHBwLVTm-TDRVyp9Kmoaxw0uZg0schn7i0koDKJw@mail.gmail.com>
	<2396674.M1Yl70Z09T@vostro.rjw.lan>
	<CACRpkda6jNsKwowdJZ6d7kua5uBPH2tZT8Ka9vheEiPjvEJuUg@mail.gmail.com>
	<20121106093904.GM24532@intel.com>
Date: Tue, 6 Nov 2012 11:15:21 +0100
Message-ID: <CACRpkdaNqjHenMyPbEEFpE+5mvWqHsMNO3T3H=NM4X7TxU-sGw@mail.gmail.com>
Subject: Re: [PATCH 1/3] gpio / ACPI: add ACPI support
From: Linus Walleij <linus.walleij@linaro.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        linux-kernel@vger.kernel.org, lenb@kernel.org,
        rafael.j.wysocki@intel.com, broonie@opensource.wolfsonmicro.com,
        grant.likely@secretlab.ca, khali@linux-fr.org, ben-linux@fluff.org,
        w.sang@pengutronix.de, linux-acpi@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 6, 2012 at 10:39 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Mon, Nov 05, 2012 at 03:40:14PM +0100, Linus Walleij wrote:
>> > I forgot to mention that we want to hook up _existing_ drivers to those things,
>> > and they already use the global GPIO numbers, don't they?
>>
>> Yes they do, usually this is either passed from the platform using platform
>> data or handled by device tree lookups to individual drivers.
>>
>> So you will have to modify each such existing driver to do ACPI
>> probe akin to the DT codepath and call acpi_get_gpio() on every pin they
>> need going forward. But that is the plan I guess.
>
> Yes, that's the plan.
>
> Do you think it is OK to go with this implementation (acpi_get_gpio()) for
> now? We will try to make sure that the gpio_get() (or whatever it will be
> called that time) supports ACPI as well.

Yes I'll be OK with it but I don't dare to merge it unless Grant
ACKs it.

Yours,
Linus Walleij