From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EC2C433EF for ; Mon, 28 Mar 2022 15:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244226AbiC1PIH (ORCPT ); Mon, 28 Mar 2022 11:08:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244186AbiC1PHu (ORCPT ); Mon, 28 Mar 2022 11:07:50 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56DEE42493 for ; Mon, 28 Mar 2022 08:06:09 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id y38so23883453ybi.8 for ; Mon, 28 Mar 2022 08:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M/wRiyThS5X8/D2KX8GPji/87UrigbGUnnN2Y5aIQZk=; b=yV5Sdnq4Kjd2UWp/LZ5lwEEIERJNIr6KcM46CNCVWFvx5wlzaJKddNK3VRi9pv7R2o hWLbRfqsYLG0O6BNwadNXFRL0YPv+6GRHkR0IzKLPhfmrUR2KryNXljHadxnyCDBIKfG KF3hEMCHNIbTbUadbfHl44Bxavmpj4Yv1hA3CuM83B2CxsfvMWvxfFESE+lhkcc2sl81 sVn2fmUkIK1jSq6CSafEfGsW+woSpsvXDMkS8B+IG38HEM9XFKMRr8RrXUF/P0GXJxbn 0RCKTCb0nMdQINyuCCC1bFgIRbmReMA7sVoFZOdeeWwD8F4hNP9k17WhtrZi3ge5CPd4 ikkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M/wRiyThS5X8/D2KX8GPji/87UrigbGUnnN2Y5aIQZk=; b=MYwP5AijEsRoRwCmdm1TYMylaaxHRvnq5r85IarYrTJm80B/87L63ZXhX/P0Qgt9CZ 4BH/Tw+v5UFd6GT8hYD7zLyW9kT8ZN9mwVixDoMl0kTLsMW0BXWlJizSPtjSJXfdQi+Q 8qLXstlf7nfbuKQtNjJRi2H+R9IJ/dNXpxqNP7kmI61jh9TuF4SS8GyuwVpoNa91IKQl ZwfxiCVF5ewa29hZcG5IKR/WTSuqK+GkgT1VEPySXJweN8xvF4lJxmd7/lt/p1A7mNPm s2CEpCDD3Asp7S4IyjoFklR316tCMkLfWci04/8ZCJ1EHX+ikx8qK6D8+o0O8KZQsPog Zz1w== X-Gm-Message-State: AOAM533hxhZUsIKevm2ea2jI2YwAq2hIcx7R/GHycamDJAp/2xmv3wDB 9EsW9p71X+AZ1p/OVLSvDh9JNFdWf9m5Hmypq9c1Vw== X-Google-Smtp-Source: ABdhPJyBvWP4T/nWYSh2/FjJMHmzkTwu66lNSkHUz/fBNP/OZSAqAsPGed14FjOgCZ7TguMcw0Nj5dmdm+VJ9v0F0CI= X-Received: by 2002:a25:ab64:0:b0:633:6d02:ebc8 with SMTP id u91-20020a25ab64000000b006336d02ebc8mr23196123ybi.492.1648479968482; Mon, 28 Mar 2022 08:06:08 -0700 (PDT) MIME-Version: 1.0 References: <20220321042142.69239-1-frank@zago.net> <20220321042142.69239-3-frank@zago.net> In-Reply-To: <20220321042142.69239-3-frank@zago.net> From: Linus Walleij Date: Mon, 28 Mar 2022 17:05:57 +0200 Message-ID: Subject: Re: [PATCH v4 2/3] gpio: ch341: add MFD cell driver for the CH341 To: frank zago Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Bartosz Golaszewski , Wolfram Sang , Johan Hovold , linux-usb@vger.kernel.org, Lee Jones , linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frank, thanks for your patch! I see you already got a bunch of homework from Andy, I will do a more thorough review on the next iteration, just a few things: On Mon, Mar 21, 2022 at 5:21 AM frank zago wrote: > The GPIO interface offers 16 GPIOs. 6 are read/write, and 10 are > read-only. > > Signed-off-by: frank zago (...) > +config GPIO_CH341 > + tristate "CH341 USB adapter in GPIO/I2C/SPI mode" > + depends on MFD_CH341 I would add default MFD_CD341 This way it gets selected automatically if the MFD module gets selected. (I suspect you should do the same with the I2C module). > +#include > +#include > +#include > +#include > +#include Use Yours, Linus Walleij