From: Linus Walleij <linus.walleij@linaro.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: jdike@addtoit.com, Richard Weinberger <richard@nod.at>,
anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Gow <davidgow@google.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency
Date: Mon, 16 Dec 2019 11:39:37 +0100 [thread overview]
Message-ID: <CACRpkdaTJej2zFX0y7mAYymBdGNvHpp3VyU0kOd=ScA_gMAf-A@mail.gmail.com> (raw)
In-Reply-To: <20191211192742.95699-2-brendanhiggins@google.com>
On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
> Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
> drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
> ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
Patch applied but I augmented it with the recently added
OF dependency so it now says:
depends on OF && HAS_IOMEM
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-12-16 10:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-16 8:42 ` Linus Walleij
2019-12-16 9:31 ` Arnd Bergmann
2019-12-16 10:39 ` Linus Walleij [this message]
2020-01-23 22:15 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
2020-01-09 15:23 ` Miquel Raynal
2020-01-25 2:12 ` Brendan Higgins
2020-01-25 15:28 ` Miquel Raynal
2020-01-27 19:00 ` Brendan Higgins
2020-01-30 19:50 ` Miquel Raynal
2020-01-30 19:55 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
2019-12-12 5:45 ` Radhey Shyam Pandey
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
2019-12-12 19:36 ` LABBE Corentin
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
2019-12-14 11:28 ` Greg Kroah-Hartman
2020-01-23 22:16 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
2019-12-12 0:12 ` Joel Stanley
2019-12-12 0:30 ` Brendan Higgins
2019-12-16 6:01 ` Joel Stanley
2020-01-27 9:46 ` Brendan Higgins
2020-01-31 3:43 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdaTJej2zFX0y7mAYymBdGNvHpp3VyU0kOd=ScA_gMAf-A@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=jdike@addtoit.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).