From: Linus Walleij <linus.walleij@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Nishanth Menon <nm@ti.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
Gary Bisson <gary.bisson@boundarydevices.com>
Subject: Re: [PATCH] pinctrl: core: Fix regression caused by delayed work for hogs
Date: Fri, 13 Jan 2017 16:26:23 +0100 [thread overview]
Message-ID: <CACRpkdaWo54ByCa=1Mr1v_O4ANR=OXehsR0Hg65pj9M9jzMDtg@mail.gmail.com> (raw)
In-Reply-To: <20170111221334.26194-1-tony@atomide.com>
On Wed, Jan 11, 2017 at 11:13 PM, Tony Lindgren <tony@atomide.com> wrote:
> Commit df61b366af26 ("pinctrl: core: Use delayed work for hogs") caused a
> regression at least with sh-pfc that is also a GPIO controller as
> noted by Geert Uytterhoeven <geert@linux-m68k.org>.
>
> As the original pinctrl_register() has issues calling pin controller
> driver functions early before the controller has finished registering,
> we can't just revert commit df61b366af26. That would break the drivers
> using GENERIC_PINCTRL_GROUPS or GENERIC_PINMUX_FUNCTIONS.
>
> So let's fix the issue with the following steps as a single patch:
>
> 1. Revert the late_init parts of commit df61b366af26.
>
> The late_init clearly won't work and we have to just give up
> on fixing pinctrl_register() for GENERIC_PINCTRL_GROUPS and
> GENERIC_PINMUX_FUNCTIONS.
>
> 2. Split pinctrl_register() into two parts
>
> By splitting pinctrl_register() into pinctrl_init_controller()
> and pinctrl_create_and_start() we have better control over when
> it's safe to call pinctrl_create().
>
> 3. Introduce a new pinctrl_register_and_init() function
>
> As suggested by Linus Walleij <linus.walleij@linaro.org>, we
> can just introduce a new function for the controllers that need
> pinctrl_create() called later.
>
> 4. Convert the four known problem cases to use new function
>
> Let's convert pinctrl-imx, pinctrl-single, sh-pfc and ti-iodelay
> to use the new function to fix the issues. The rest of the drivers
> can be converted later. Let's also update Documentation/pinctrl.txt
> accordingly because of the known issues with pinctrl_register().
>
> Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Gary Bisson <gary.bisson@boundarydevices.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
OK patch applied.
Yours,
Linus Walleij
prev parent reply other threads:[~2017-01-13 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 22:13 [PATCH] pinctrl: core: Fix regression caused by delayed work for hogs Tony Lindgren
2017-01-12 8:43 ` Geert Uytterhoeven
2017-01-12 15:48 ` Tony Lindgren
2017-01-13 15:26 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdaWo54ByCa=1Mr1v_O4ANR=OXehsR0Hg65pj9M9jzMDtg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gary.bisson@boundarydevices.com \
--cc=grygorii.strashko@ti.com \
--cc=haojian.zhuang@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).