From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbcF2Hnc (ORCPT ); Wed, 29 Jun 2016 03:43:32 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:36843 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbcF2Hnb (ORCPT ); Wed, 29 Jun 2016 03:43:31 -0400 MIME-Version: 1.0 In-Reply-To: <20160626024652.5081-7-paul.gortmaker@windriver.com> References: <20160626024652.5081-1-paul.gortmaker@windriver.com> <20160626024652.5081-7-paul.gortmaker@windriver.com> From: Linus Walleij Date: Wed, 29 Jun 2016 09:35:18 +0200 Message-ID: Subject: Re: [PATCH 06/19] pinctrl: imx35: make it explicitly non-modular To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Dong Aisheng , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 26, 2016 at 4:46 AM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pinctrl/freescale/Kconfig:config PINCTRL_IMX35 > drivers/pinctrl/freescale/Kconfig: bool "IMX35 pinctrl driver" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init was not in use by this driver, the init ordering > remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij > Cc: Dong Aisheng > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Patch applied. Yours, Linus Walleij