From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B2B6C433F5 for ; Sun, 1 May 2022 21:41:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355429AbiEAVot (ORCPT ); Sun, 1 May 2022 17:44:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355387AbiEAVoo (ORCPT ); Sun, 1 May 2022 17:44:44 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F0326253 for ; Sun, 1 May 2022 14:41:16 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id w187so23328200ybe.2 for ; Sun, 01 May 2022 14:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W/jgoNHxZ0Bthjb3T+ueRSX0j4+9gCUm19tM0i8wHwg=; b=IhdUZeb/2gtz8F3Rms9jbaMLWrgk9MgQ3AsdLov4FK3Mlzh5dB5SkLKChzGtZ8IxYp G5ca/lqDXuEA1sPhEVPyIa/Q2PZiKGOf7YhqAw/IHqTaRS3tfuxe5vxPkiXcKnSSY+3S 7ppRg4LQk2Uv9wR63si1SSy6XwiVLL7qFkHNlWqfSlqs0yLXj9GT9hsHOGdPMLeWa4Z5 yi/NgdTd0E83Yl+jmXtf3Jut6MVJU1arAhV4mge1OLZtShQSG4PEDF87HlZJ7jAAsXMq NvpTbNSoJchK+6lkQfko/fVrXtHXd/BqfkBEUyV3r++82iVekijvFZHqUIOR58kizRlW mQmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W/jgoNHxZ0Bthjb3T+ueRSX0j4+9gCUm19tM0i8wHwg=; b=4bwFz9+SUXZY7hgjrqck9LTu4HalzpjVcDASqDylVmN4EngQR7FKNuuk1jaN+8ibVB bhteExa+yfZGcdNHDMzRZvi4yhzp4qVYbaidPBsqWx+wVdTNldD8XYLRabmklDGGQBps Hn3Eot2Qmh3mpGzPr42C6tUQEDXC/IXtC3Q69ZmdvRAHaV58unSspprK5g2n8JCPc5IW m0ry7x/jIPBIMuoOkXAFikbrpUBa7jb2YWeOqs931uD1MBFeY4IzFnKTRkDhFCoMg0Gj MwYxLwmqLa1mRlSwQWTMChQYpJIN+FFzZvUzahtzMOG1fen88G57B8os9Dwj3q9kpma5 4QVQ== X-Gm-Message-State: AOAM533ab5qp6apyx6Z6wOvhTMbQFJXok0j1NJ2pGQo6gekRPOC6nlSO xi6T/g6xIJIu7VPfeMp0pTL1XyOVoZN7c/BNrAeo9w== X-Google-Smtp-Source: ABdhPJxQ+Z2MWNpw84rRmTsi9PlMVLP8E3NHAP2/94wScknuaOhbNIB27Lulcn5Bn4eH53rZYcEIPCq8gj4+tkqqRT4= X-Received: by 2002:a25:2905:0:b0:649:7a2b:ca72 with SMTP id p5-20020a252905000000b006497a2bca72mr2453918ybp.492.1651441275908; Sun, 01 May 2022 14:41:15 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-19-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-19-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:41:04 +0200 Message-ID: Subject: Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Cc: Philipp Zabel > Cc: Paul Parsons > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann (...) > +static struct gpiod_lookup_table hx4700_audio_gpio_table = { > + .dev_id = "hx4700-audio", > + .table = { > + GPIO_LOOKUP("gpio-pxa", GPIO75_HX4700_EARPHONE_nDET, > + "earphone-ndet", GPIO_ACTIVE_HIGH), This looks wrong. The n in nDET in the end of the name of the GPIO line means active low does it not? What I usually do when I see this is to properly set it to GPIO_ACTIVE_LOW in the descriptor table, then invert the logic where it's getting used. Also rename to earphone-det instead of -ndet > + GPIO_LOOKUP("gpio-pxa", GPIO92_HX4700_HP_DRIVER, > + "hp-driver", GPIO_ACTIVE_HIGH), > + GPIO_LOOKUP("gpio-pxa", GPIO107_HX4700_SPK_nSD, > + "spk-nsd", GPIO_ACTIVE_HIGH), Same here. Rename spk-sd Yours, Linus Walleij