linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Roger Quadros <rogerq@ti.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpiolib: Fix unaligned used of reference counters
Date: Wed, 8 Jun 2016 10:41:37 +0200	[thread overview]
Message-ID: <CACRpkdak7ZT7fyVpfZB26m7xshJssV-8dxNWjOE22j6L2EUO0w@mail.gmail.com> (raw)
In-Reply-To: <1464973802-9286-2-git-send-email-ricardo.ribalda@gmail.com>

On Fri, Jun 3, 2016 at 7:10 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:

> gpiolib relies on the reference counters to clean up the gpio_device
> structure.
>
> Although the number of get/put is properly aligned on gpiolib.c
> itself, it does not take into consideration how the referece counters
> are affected by other external functions such as cdev_add and device_add.
>
> Because of this, after the last call to put_device, the reference counter
> has a value of +3, therefore never calling gpiodevice_release.
>
> Due to the fact that some of the device  has already been cleaned on
> gpiochip_remove, the library will end up OOPsing the kernel (e.g. a call
> to of_gpiochip_find_and_xlate).
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Again, thanks for fixing my stupid mistakes.

Applied and tagged for stable.

Yours,
Linus Walleij

  reply	other threads:[~2016-06-08  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 17:10 [PATCH 1/2] gpiolib: Fix NULL pointer deference Ricardo Ribalda Delgado
2016-06-03 17:10 ` [PATCH 2/2] gpiolib: Fix unaligned used of reference counters Ricardo Ribalda Delgado
2016-06-08  8:41   ` Linus Walleij [this message]
2016-06-08  8:39 ` [PATCH 1/2] gpiolib: Fix NULL pointer deference Linus Walleij
2016-06-08  9:46   ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdak7ZT7fyVpfZB26m7xshJssV-8dxNWjOE22j6L2EUO0w@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=gnurou@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    --cc=rogerq@ti.com \
    --subject='Re: [PATCH 2/2] gpiolib: Fix unaligned used of reference counters' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).