From: Linus Walleij <linus.walleij@linaro.org>
To: Drew Fustini <drew@beagleboard.org>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jason Kridner" <jkridner@beagleboard.org>,
"Robert Nelson" <robertcnelson@beagleboard.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
Date: Thu, 28 Jan 2021 13:01:00 +0100 [thread overview]
Message-ID: <CACRpkdam4gY3iU1DBtczgdnxQ-t0OkrRMZ-Y9e1W0FQOrYnndw@mail.gmail.com> (raw)
In-Reply-To: <20210127000303.436595-1-drew@beagleboard.org>
On Wed, Jan 27, 2021 at 1:04 AM Drew Fustini <drew@beagleboard.org> wrote:
> Based on linux-gpio discussion [1], it is best practice to make the
> gpio-line-names unique. Generic names like "[ethernet]" are replaced
> with the name of the unique signal on the AM3358 SoC ball corresponding
> to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> represent "not connected".
>
> [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
This certainly looks better!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-01-28 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 0:03 [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names Drew Fustini
2021-01-27 0:03 ` [PATCH 2/2] ARM: dts: am335x-boneblack.dts: " Drew Fustini
2021-01-28 12:01 ` Linus Walleij
2021-02-01 9:45 ` Bartosz Golaszewski
2021-01-28 12:01 ` Linus Walleij [this message]
2021-02-01 9:44 ` [PATCH 1/2] ARM: dts: am335x-pocketbeagle: " Bartosz Golaszewski
2021-02-04 6:58 ` Tony Lindgren
2021-02-04 7:46 ` Drew Fustini
2021-02-12 8:31 ` Linus Walleij
2021-03-24 12:00 ` Tony Lindgren
2021-03-24 22:33 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdam4gY3iU1DBtczgdnxQ-t0OkrRMZ-Y9e1W0FQOrYnndw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bcousson@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@beagleboard.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).