From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933566AbcFQQKe (ORCPT ); Fri, 17 Jun 2016 12:10:34 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:36181 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932683AbcFQQKc (ORCPT ); Fri, 17 Jun 2016 12:10:32 -0400 MIME-Version: 1.0 In-Reply-To: <1466112442-31105-16-git-send-email-daniel.lezcano@linaro.org> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-16-git-send-email-daniel.lezcano@linaro.org> From: Linus Walleij Date: Fri, 17 Jun 2016 18:10:25 +0200 Message-ID: Subject: Re: [PATCH V2 15/63] clocksource/drivers/clksrc-dbx500: Convert init function to return error To: Daniel Lezcano Cc: Thomas Gleixner , "linux-kernel@vger.kernel.org" , "moderated list:ARM/Ux500 ARM ARC..." Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 11:26 PM, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano Acked-by: Linus Walleij Yours, Linus Walleij